Update and removed obsgroup-ids on the NCD fellow-up form #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnball
requested changes
Feb 28, 2023
There was a problem hiding this comment.
Nice work @tommyiversonj . Where I left a comment, I would recommend that you , remove the obsgroup, but add the dateLabel on the obs. Otherwise the date of test is not unique or connected with the obs.
| </tr> | ||
| </includeIf> | ||
|
|
||
| <includeIf velocityTest="$pt_has_lf"> | ||
| <tr> | ||
| <obsgroup groupingConceptId="PIH:HEPATITIS C TEST - QUALITATIVE"> |
There was a problem hiding this comment.
This section won't work. You can either add a construct/obsgroup OR add a dateLabel attribute to the Hep C test obs
dateLabel: Text to display after the obs.value widget and before the obs.datetime widget (obs.obs_datetime). Specifying this implies showDate="true".
OPTIONAL
Example:
There was a problem hiding this comment.
@lnball Thanks for the feedback
There was a problem hiding this comment.
@lnball Kindly double-check my update. Hope am correct!
| </tr> | ||
| </includeIf> | ||
|
|
||
| <includeIf velocityTest="$pt_has_lf or $pt_has_rf"> | ||
| <tr> | ||
| <obsgroup groupingConceptId="CIEL:161472"> |
| </tr> | ||
| </includeIf> | ||
|
|
||
| <includeIf velocityTest="$$pt_has_rf"> | ||
| <tr> | ||
| <obsgroup groupingConceptId="PIH:11457"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.