Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow composer/pcre Version 1 and 2 #4347

Merged

Conversation

sprankhub
Copy link

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • [] Documentation is updated as necessary

Why this change is needed?

See #4346 for an explanation.

@oleibman oleibman merged commit 6a972b5 into PHPOffice:release1291 Feb 7, 2025
14 checks passed
@oleibman
Copy link
Collaborator

oleibman commented Feb 7, 2025

Thank you for your contribution.

@sprankhub sprankhub deleted the release1291-pcre-constraint branch February 7, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants