improved performance of column width calculation for spreadsheets wit… #1628
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
| * | ||
| * @return bool | ||
| */ | ||
| public function isMergeRangeValueCell2($mergeRange) |
There was a problem hiding this comment.
Idea for perhaps better name: isFirstInMergedRange
| * | ||
| * @var array | ||
| */ | ||
| private static $_rangeBoundariesCache = []; |
There was a problem hiding this comment.
Using underscore in variable name is almost never used in this project.
There was a problem hiding this comment.
Good catch. We're trying to move away from underscore usage. So new usage should not be added again.
| * | ||
| * @return bool | ||
| */ | ||
| public function isMergeRangeValueCell2($mergeRange) |
There was a problem hiding this comment.
All new methods must declare their typing
| * | ||
| * @var array | ||
| */ | ||
| private static $_rangeBoundariesCache = []; |
There was a problem hiding this comment.
Good catch. We're trying to move away from underscore usage. So new usage should not be added again.
|
No update in over 2.5 years. Closing. |
improved performance of column width calculation for spreadsheets with many merged cells
This is:
Checklist:
Why this change is needed?
Creating Spreadsheets with many merged cells was very slow.
This was (to some degree) because of a many (unnecesserily) repeated calls to Coordinate::rangeBoundaries(), Cell::isInRange() and Cell::getMergeRange().