Skip to content

Plot without vis spec without ids_per_plot #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025

Conversation

PaulJonasJost
Copy link
Collaborator

If not providing "ids_per_plot" it automatically assumes that "groupy_by='observable'". This should be fixed by creating the ids_per_plot based on the selected groupy by.

…_by='observable'". This should be fixed by creating the ids_per_plot based on the selected groupy by.
@PaulJonasJost PaulJonasJost requested a review from a team as a code owner May 7, 2025 13:04
@PaulJonasJost PaulJonasJost self-assigned this May 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.00%. Comparing base (0e90fd9) to head (9fa9045).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #386   +/-   ##
========================================
  Coverage    74.00%   74.00%           
========================================
  Files           58       58           
  Lines         6470     6470           
  Branches      1115     1115           
========================================
  Hits          4788     4788           
  Misses        1260     1260           
  Partials       422      422           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks.

@PaulJonasJost PaulJonasJost enabled auto-merge (squash) May 7, 2025 15:28
@PaulJonasJost PaulJonasJost merged commit 7a8ad8a into develop May 7, 2025
13 checks passed
@PaulJonasJost PaulJonasJost deleted the plot_without_vis_spec branch May 7, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants