Skip to content

lint: Don't fail on missing noiseFormula #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 25, 2025

Handle missing noiseFormula in assert_overrides_match_parameter_count.

Fixes #219.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.55%. Comparing base (101c79c) to head (4e248ba).

Files with missing lines Patch % Lines
petab/v1/lint.py 50.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #367   +/-   ##
========================================
  Coverage    74.55%   74.55%           
========================================
  Files           57       57           
  Lines         6075     6075           
  Branches      1057     1057           
========================================
  Hits          4529     4529           
  Misses        1141     1141           
  Partials       405      405           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review March 27, 2025 14:36
@dweindl dweindl requested a review from a team as a code owner March 27, 2025 14:36
@dweindl dweindl merged commit 017746e into PEtab-dev:develop Mar 27, 2025
7 checks passed
@dweindl dweindl deleted the fix_219 branch March 27, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validator does not check for required column noiseFormula in observables table
3 participants