Add evaluate: bool argument to math parser
#365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #365 +/- ##
===========================================
+ Coverage 74.55% 74.57% +0.02%
===========================================
Files 57 57
Lines 6075 6080 +5
Branches 1057 1058 +1
===========================================
+ Hits 4529 4534 +5
Misses 1141 1141
Partials 405 405 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
evaluate_gh-363
branch
from
d763c19 to
2ea22ab
Compare
Merged
So far, when math expressions were parsed, they were evaluated as far as possible. This was not always desirable. Now, this optional as far as conveniently possible. Closes PEtab-dev#363.
dweindl
force-pushed
the
evaluate_gh-363
branch
from
2ea22ab to
27a2b28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, when math expressions were parsed, they were evaluated as far as possible. This was not always desirable.
Now, this optional as far as conveniently possible.
Closes #363.