Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDOK-16629 use pydantic #133

Merged
merged 9 commits into from
Nov 18, 2024
Merged

PDOK-16629 use pydantic #133

merged 9 commits into from
Nov 18, 2024

Conversation

roelarents
Copy link
Contributor

Description

use pydantic instead of dicts for the schema. so it's easier to expand with new functionality

Type of change

  • Improvement of existing feature
  • Breaking change

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

@roelarents roelarents force-pushed the pdok-16629-use-pydantic branch from 68183e4 to 291fe11 Compare November 13, 2024 09:17
@gerdos82 gerdos82 merged commit 725a330 into master Nov 18, 2024
10 checks passed
@roelarents roelarents deleted the pdok-16629-use-pydantic branch November 18, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants