Sync forked repo #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gulp must be started from the project root folder, not from the VIEW_CODE folder
This substantially reduces the size of the custom.js file. A source map is available when running locally.
This fixes Node 8 support, #66
…lter view selection options (#77)
Proxied requests to primoExploreLogin will not work for SAML authentication (server returns a 500 error). This change adds an optional --saml parameter to the gulp run task. Setting the --saml parameter instructs the local proxy server to redirect (vs proxy) any primoExploreLogin requests to the target host. When SAML authentication is complete, Primo will redirect the browser back to localhost.
Redirect SAML login requests
Being new to primo development I didn't understand what was being communicated here until a more experienced primo developer explained the file concatenation. This PR is an attempt to clarify the feature's functionality in the README
* add angularjs-annotate to babelify plugins * return from gulp task custom-js prevents async execution this fixes a problem when running create-package and browserify * update gulp-sass version to 3.1.0 to support alpine linux * fix gulp task app-css for primo november 2018 release and newer * fix #98 by renaming all scsss to www in 'extract-scss-files' task * Create LICENSE * add fonts folder to zip package * fix extract-scss-files task * fix after upstream merge Co-authored-by: gilax <[email protected]> Co-authored-by: Noam Amit <[email protected]>
* Adds definePlugin functionality * Fixes babelConfig refactor * Allows for environment flag; only uglifies production * Adds build env and time to package Co-authored-by: Noam Amit <[email protected]>
Bug prevented packages from building SCSS files correctly.
* update minimum node version to 10.15update dependencies, minor code changes * Update README.md for changes to nodejs v10.15.3 * resolve conflicts Co-authored-by: noama <[email protected]>
- in the absence of an .npmignore, npm defers to the .gitignore in order to decide what it includes/excludes from the final package - when it does this, it doesn't look into the .gitignores in the rest of the repo - this means that the 'primo-explore/*' directories are seen as empty and not included in the end result - this leads to a disconnect between what's in the repo and what's in the installed package, complicating/confusing future attempts at automation/scripting note: if the first .gitignore contains the logic for unhiding the primo-explore/*/.gitignores, the code inside of them isn't doing anything, so let's remove the redundancy
Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.5. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.5) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Noam Amit <[email protected]>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Noam Amit <[email protected]>
* add angularjs-annotate to babelify plugins * return from gulp task custom-js prevents async execution this fixes a problem when running create-package and browserify * update gulp-sass version to 3.1.0 to support alpine linux * fix gulp task app-css for primo november 2018 release and newer * fix #98 by renaming all scsss to www in 'extract-scss-files' task * Create LICENSE * add fonts folder to zip package * fix extract-scss-files task * fix after upstream merge * fix watch in gulp task watch-custom-scss * watch-custom-scss allowEmpty * gulp.src scss allowEmpty * gulp.series custom-img * allowEmpty custom main.scss * glup.watch usePolling for docker Co-authored-by: gilax <[email protected]> Co-authored-by: Noam Amit <[email protected]>
This works around a problem introduced by gulp 4 / vinyl 2: miickel/gulp-angular-templatecache#153
* fix node-modules tasks, use gulp4-run-sequence and add callback * fix custom-js callback, needed for create-package * add return gulp.src in custom-html-templates * fix callback in custom-html-templates * fix callback in custom-js task
…y 2020 release (#121) note: will need to run `npm publish` (after any necessary build) to make it effective
Update README.md
Merge pull request #140 from ExLibrisGroup/master
upgrade dependencies to support Node v16 LTS
Update to config.js documentation
fixed issue where some delivery Alma links were not proxied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating to latest for VE support