Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加对下载器版本要求的提示,优化表达、格式,同步修改英文文档 #33

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

CreeperAWA
Copy link
Contributor

@CreeperAWA CreeperAWA commented Jan 30, 2025

Summary by CodeRabbit

  • 文档更新
    • 为 BitComet 添加了版本兼容性警告,仅支持 v2.10 Beta6 [20240928] 及以上版本
    • 为 qBittorrent 添加了版本兼容性和安全性警告,仅支持 v4.5.0 及以上版本
    • 明确不支持 XDown 下载器
    • 增加了安全配置建议,包括设置强密码和正确的网络配置

Copy link
Contributor

coderabbitai bot commented Jan 30, 2025

变更概述

概览

本次拉取请求主要更新了 BitComet 和 qBittorrent 的文档,增加了版本兼容性警告和使用建议。对于 BitComet,要求使用 v2.10 Beta6 [20240928] 或更高版本;对于 qBittorrent,要求使用 v4.5.0 或更高版本。文档还明确了对不兼容版本的支持政策,并补充了一些安全和配置建议。

变更

文件路径 变更摘要
docs/downloader/BitComet.md 添加 BitComet 版本兼容性警告
docs/downloader/qBittorrent.md 新增版本兼容性警告,扩展安全建议,澄清多连接配置
i18n/en/docusaurus-plugin-content-docs/current/downloader/BitComet.md 添加 BitComet 版本兼容性警告
i18n/en/docusaurus-plugin-content-docs/current/downloader/qBittorrent.md 新增版本兼容性警告,澄清多连接配置

可能相关的 PR

建议的审阅者

  • Gaojianli
  • Ghost-chu

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (7)
docs/downloader/qBittorrent.md (3)

13-17: 版本要求警告的表述建议优化

建议调整表述以更清晰地传达信息:

-PeerBanHelper 仅兼容 qBittorrent `v4.5.0` 或更高版本,不兼容 XDown。即使你在不合要求的下载器上成功运行 PeerBanHelper,我们也不会提供任何支持。
+PeerBanHelper 仅兼容 qBittorrent `v4.5.0` 及更高版本,且与 XDown 不兼容。如果您在不符合要求的下载器上运行 PeerBanHelper,即使能够成功运行,我们也不会提供任何技术支持。

36-41: 安全提示建议补充具体建议

建议为每个安全提示添加具体的操作建议:

 **安全提示**
-请设置强密码以保护您的 qBittorrent
-如果只在本地使用,建议将访问限制为 127.0.0.1
-确保防火墙配置正确,只开放必要端口
+- 请设置强密码以保护您的 qBittorrent(建议使用至少12位包含大小写字母、数字和特殊字符的密码)
+- 如果只在本地使用,强烈建议在 IP 地址栏中填写 127.0.0.1 以限制访问
+- 确保防火墙配置正确,仅开放 WebUI 所需的端口,并建议设置访问白名单

55-57: 自动配置说明建议优化格式

建议调整格式以提高可读性:

-在 PeerBanHelper `v7.2.0` 及以上版本,下载器连接到 PeerBanHelper 时,PeerBanHelper 会自动关闭"允许来自同一 IP 地址的多个连接"选项,如果你使用的版本正确,则无需手动配置此选项。
+从 PeerBanHelper `v7.2.0` 版本开始,当下载器连接到 PeerBanHelper 时,系统会自动关闭"允许来自同一 IP 地址的多个连接"选项。
+
+> 如果您使用的是 `v7.2.0` 或更高版本,则无需手动配置此选项。
docs/downloader/BitComet.md (1)

13-17: 版本要求警告的表述建议统一

为保持与 qBittorrent 文档的一致性,建议调整表述:

-PeerBanHelper 仅兼容 BitComet `v2.10 Beta6 [20240928]` 或更高版本。即使你在不合要求的下载器上成功运行 PeerBanHelper,我们也不会提供任何支持。
+PeerBanHelper 仅兼容 BitComet `v2.10 Beta6 [20240928]` 及更高版本。如果您在不符合要求的下载器上运行 PeerBanHelper,即使能够成功运行,我们也不会提供任何技术支持。
i18n/en/docusaurus-plugin-content-docs/current/downloader/qBittorrent.md (2)

13-17: 建议优化英文版本要求的表述

建议调整英文表述以提高准确性:

-The PeerBanHelper is only compatible with qBittorrent versions `v4.5.0` and higher, and it is not compatible with XDown. Even if you manage to run PeerBanHelper successfully on an incompatible downloader, we will not provide any support for such configurations.
+PeerBanHelper is only compatible with qBittorrent version `v4.5.0` or higher and is incompatible with XDown. Even if you manage to run PeerBanHelper successfully on an incompatible downloader, we will not provide any technical support.
🧰 Tools
🪛 LanguageTool

[style] ~15-~15: Consider using “incompatible” to avoid wordiness.
Context: ...versions v4.5.0 and higher, and it is not compatible with XDown. Even if you manage to run P...

(NOT_ABLE_PREMIUM)


54-58: 建议优化英文自动配置说明的格式

建议调整格式以提高可读性:

-From version `v7.2.0` and above, when a downloader connects to PBH, the option "Allow multiple connections from
-the same IP address" will automatically be disabled by qBittorrent. Therefore, if you are using the correct
-version, there is no need for manual configuration of this setting.
+Starting from version `v7.2.0`, when a downloader connects to PeerBanHelper, the option "Allow multiple connections from the same IP address" will be automatically disabled.
+
+> If you are using version `v7.2.0` or higher, there is no need to configure this setting manually.
i18n/en/docusaurus-plugin-content-docs/current/downloader/BitComet.md (1)

13-17: 建议统一英文版本要求的表述风格

为保持与 qBittorrent 文档的一致性,建议调整表述:

-The PeerBanHelper is only compatible with BitComet versions `v2.10 Beta6 [20240928]` and higher. Even if you manage to run PeerBanHelper successfully on an incompatible downloader, we will not provide any support for such configurations.
+PeerBanHelper is only compatible with BitComet version `v2.10 Beta6 [20240928]` or higher. Even if you manage to run PeerBanHelper successfully on an incompatible downloader, we will not provide any technical support.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f762457 and 7b79766.

📒 Files selected for processing (4)
  • docs/downloader/BitComet.md (1 hunks)
  • docs/downloader/qBittorrent.md (3 hunks)
  • i18n/en/docusaurus-plugin-content-docs/current/downloader/BitComet.md (1 hunks)
  • i18n/en/docusaurus-plugin-content-docs/current/downloader/qBittorrent.md (3 hunks)
🧰 Additional context used
🪛 LanguageTool
i18n/en/docusaurus-plugin-content-docs/current/downloader/qBittorrent.md

[style] ~15-~15: Consider using “incompatible” to avoid wordiness.
Context: ...versions v4.5.0 and higher, and it is not compatible with XDown. Even if you manage to run P...

(NOT_ABLE_PREMIUM)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant