-
Couldn't load subscription status.
- Fork 10
Rework the metrics used by the FileTree #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
45cabff
Calculate coverage instead of "unused code"
Pennycook f5f01b0
Adjust summary report test for "Coverage" label
Pennycook 9db7c02
Add coverage() function to compute coverage
Pennycook 1a8daea
Split "Used / Total" column into SLOC + Coverage
Pennycook 80bf5ba
Fix handling of corner-cases in coverage
Pennycook 3dc84b8
Adjust FileTree tests for new SLOC format
Pennycook fc4f981
Add new FileTree tests for coverage string
Pennycook f18a11d
Simplify "Platform Set" in FileTree header
Pennycook db9bfd2
Refactor coverage to accept platform parameter
Pennycook c79431f
Add function to compute average coverage
Pennycook 33c1352
Add tests for average_coverage_str formatting
Pennycook fe7b88a
Remove utilization in favor of average coverage
Pennycook 6254614
Remove divergence from tree report
Pennycook 26de892
Add tests for coverage function
Pennycook 9a1235b
Add tests for average_coverage function
Pennycook 384c977
Add documentation for platform coverage
Pennycook 89144ea
Add missing coverage numbers to tutorial
Pennycook e45edc6
Clarify average_coverage docstring
Pennycook 29fc127
Add missing Returns section to coverage docstrings
Pennycook File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest a minor rephrasing - not sure if it's just my brain but when I mention reductions in text I try and move it away from the original quantity and be explicit about what the reduction is over.
In this case, "...percentage of lines in
setmaprequired by each platform in the suppliedplatformsset, **averaged over the set of platforms." Similar to how you've written it for the output description.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broke my brain a little bit. 😆
I think which form I'd prefer to use depends on context. I'd definitely say something like "temperature, averaged over volume", but in this case I think it's important to emphasize at the beginning of the sentence that what we are returning is an average .
I've tried to split the difference, and made two changes. In e45edc6, I broke down the behavior of the function to explain what we're computing:
...and then in 29fc127 I added the missing
Returnssections, with shorter sentences that are hopefully easier to parse, e.g.: