Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL logic directly to the schema reference from the docs. #268

Merged
merged 13 commits into from
Aug 28, 2024

Conversation

jenningsanderson
Copy link
Collaborator

@jenningsanderson jenningsanderson commented Aug 13, 2024

Description

Brief description of the business purpose and effect of the pull request.

  • Adds the SQL logic for each theme directly into the schema reference.
  • Move descriptions of names, height, and 3d buildings from osm folder to the documentation directly.

Reference

  1. Base/Building SQL logic moved to the data-platform-tf for better testing / integration

Testing

https://dfhx9f55j8eg5.cloudfront.net/pr/268/schema/concepts/by-theme/base
https://dfhx9f55j8eg5.cloudfront.net/pr/268/schema/concepts/by-theme/buildings
https://dfhx9f55j8eg5.cloudfront.net/pr/268/schema/concepts/names

Checklist

Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.

  1. [N/A] Add relevant examples.
  2. [N/A] Add relevant counterexamples.
  3. [N/A] Update any counterexamples that became obsolete. For example, if a counterexample uses property A but is not intended to test property A's validity, and you made a schema change that invalidates property A in that counterexample, fix the counterexample to align it with your schema change.
  4. Update in-schema documentation using plain English written in complete sentences, if an update is required.
  5. Update Docusaurus documentation, if an update is required.
  6. Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.

Documentation Website

Update the hyperlink below to put the pull request number in.

Docs preview for this PR.

@jenningsanderson jenningsanderson changed the title [WIP] Add sql logic Add SQL logic directly to the schema reference from the docs. Aug 13, 2024
vcschapp
vcschapp previously approved these changes Aug 14, 2024
DavidKarlas
DavidKarlas previously approved these changes Aug 14, 2024
danabauer
danabauer previously approved these changes Aug 14, 2024
Copy link
Contributor

@danabauer danabauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good step toward documenting the daylight to overture transition!
https://github.com/OvertureMaps/tf-developer-advocacy/issues/165

vcschapp
vcschapp previously approved these changes Aug 15, 2024
Copy link
Collaborator

@vcschapp vcschapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

         ,..........   ..........,
     ,..,'          '.'          ',..,
    ,' ,'            :            ', ',
   ,' ,'             :             ', ',
  ,' ,'              :              ', ',
 ,' ,'............., : ,.............', ',
,'  '............   '.'   ............'  ',
 '''''''''''''''''';''';''''''''''''''''''
                    '''

atiannicelli
atiannicelli previously approved these changes Aug 16, 2024
Copy link
Contributor

@atiannicelli atiannicelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to review this earlier. Looks great, but I left one comment.

Copy link
Collaborator

@vcschapp vcschapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-up!

@vcschapp vcschapp merged commit d0457db into dev Aug 28, 2024
1 check passed
@vcschapp vcschapp deleted the add-sql-logic branch August 28, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants