-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bathymetry to Base #206
base: dev
Are you sure you want to change the base?
Conversation
8cd6a47
to
9eff25f
Compare
c510363
to
e5445f7
Compare
e5445f7
to
d7fc150
Compare
We should try to boot this PR up and aim for September or October release. Not rushing due to GA and post-GA freeze but should be in! |
- "$ref": ../defs.yaml#/$defs/propertyContainers/cartographyContainer | ||
required: | ||
- elevation | ||
properties: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Should we add a relationship property to reference the feature to the water body it is providing the bathymetry for?
- Should we add a property to specify what type of water body it pertains to?
I'm not too sure about the second one, but adding it for discussion. Might be useful to know if something is ocean or inland at least?
For the first one, the ID reference, it would only pertain to "things that exist in the base theme" - we don't have features for ocean water - so it would be optional.
Just throwing out ideas, but we might imagine something like:
---
id: foo
properties:
theme: base
type: bathymetry
depth: 100
water_location: inland # Can be "ocean" or "inland"
water_id: bar # Omit if there's no matching water feature, otherwise this is ID of a base/water feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
water_location
might be useful, but not sure how we can relate them to water bodies since the cross cut so many?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do they all cross-cut? I got the impression some features were for specific lakes?
Fix counterexamples that were failing due to the old names schema present, not due to their original reason for failing. This also eliminates "local" as an option for a language Addresses #265
OvertureMaps/schema-wg#151 This is a commit by vcschapp@ that builds on Ola's work from the above- referenced issue. There are two changes to the schema: 1. Road "width" moves under the "road" property. 2. Road "width" is now linearly-referenced. The following are changes from Ola's previous work: 1. In keeping with our Parquet compatibility and tooling compatibility drive, there is no option for a scalar value for "width": it must now always be a non-empty array of rules. 2. I moved "width" under "road" because it's not obvious that it's a generalized property even for all types of segment, let alone across Overture, especially with the LR facet.
This commit switches properties and enumerators from `camelCase` naming to `snake_case` naming. The purpose is to improve compatibility with SQL based tools. Because SQL uses case-insensitive identifiers for historical reasons, SQL-based tools cause problems and information loss with camel-casing because they tend to treat all identifiers as if they were alllowercase or ALLCAPS. In the Overture Schema Task Force meeting of 2024-02-07, the task force decided to adopt the snake_case proposal: OvertureMaps/schema-wg#272 The proposal originated in Jake's Schema Friction discussion document on the Overture Confluence: https://wiki.overturemaps.org/x/SQGAAQ While we believe that snake_case is slightly unconventional, and dare I (Vic) say also more unsightly in the JSON context, we feel that for SQL compatibility reasons, the pros of changing outweigh the cons.
add leisure:recreation_ground
Logic for volcanoes to turn into mountains
adding landuse for debugging, too
… Also adding missing tags to published collection of tags to be used for debugging purposes
…ema repo (#158) * bare bones reference docs for divisions * New header Removing GERS and updating header * remove everything but reference docs * Update index.mdx Add the slug for root * Fixing longtime react errors * Fixing react errors * Fix broken links * brief intro text * add link --------- Co-authored-by: Jennings Anderson <[email protected]>
One of the lines in the categories list is missing an end bracket. I've corrected it.
7cadd34
to
3f4a42b
Compare
Proposal
Add ocean and inland lakes bathymetry data. Examples below from Meta's production basemaps.
Background
The Display Maps team at Meta derived vectorized bathymetric data products from ETOPO1 and Globathy.
ETOPO (source link)
We derived 10 bands of polygons from this dataset, at the following depths:
GLOBathy (source link)
For interior water bodies, we have derived vectorized data for 10 global lakes: Lake Baikal, Lake Tanganyika, Lake Malawi, Lago Niassa, Garabogazköl, Lake Superior, Lake Michigan, Lake Ontario, Crater Lake, and Lake Tahoe. We derived 15 bands of polygons from this dataset, at the following depths:
License
ETOPO: PDDL
GLOBathy: CC0 1.0
Checklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
A
but is not intended to test propertyA
's validity, and you made a schema change that invalidates propertyA
in that counterexample, fix the counterexample to align it with your schema change.Documentation Website
Update the hyperlink below to put the pull request number in.
Docs preview for this PR.