Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bathymetry to Base #206

Open
wants to merge 88 commits into
base: dev
Choose a base branch
from
Open

Add Bathymetry to Base #206

wants to merge 88 commits into from

Conversation

jonahadkins
Copy link
Contributor

@jonahadkins jonahadkins commented May 30, 2024

Proposal

Add ocean and inland lakes bathymetry data. Examples below from Meta's production basemaps.

Screenshot 2024-05-30 at 6 08 02 PM Screenshot 2024-05-30 at 6 08 20 PM Screenshot 2024-05-30 at 6 12 44 PM Screenshot 2024-05-30 at 6 13 30 PM

Background

The Display Maps team at Meta derived vectorized bathymetric data products from ETOPO1 and Globathy.

ETOPO (source link)

We derived 10 bands of polygons from this dataset, at the following depths:

feature count depth
4,285 0
4,228 10
4,622 50
3,878 100
2,748 500
3,308 1000
4,722 1500
6,750 2000
10,309 2500
15,210 3000

GLOBathy (source link)

For interior water bodies, we have derived vectorized data for 10 global lakes: Lake Baikal, Lake Tanganyika, Lake Malawi, Lago Niassa, Garabogazköl, Lake Superior, Lake Michigan, Lake Ontario, Crater Lake, and Lake Tahoe. We derived 15 bands of polygons from this dataset, at the following depths:

feature count depth
14 100
12 200
8 300
8 400
8 500
7 600
3 700
8 800
8 900
6 1000
8 1100
4 1200
4 1300
3 1400
1 1500

License

ETOPO: PDDL

ETOPO tiles are freely available to use for all private, academic, or commercial purposes. Data is
available for download on the NOAA ETOPO landing page.
To reference the ETOPO 2022 document, please cite the following:
NOAA National Centers for Environmental Information. 2022: ETOPO 2022 15 Arc-Second
Global Relief Model. NOAA National Centers for Environmental Information.
https://doi.org/10.25921/fd45-gt74 . Accessed [date].
ETOPO 2022 metadata may be accessed here: ETOPO 2022 metadata landing page

GLOBathy: CC0 1.0

The dataset is released under an assumed CC0 1.0 Universal (CC0 1.0) Public Domain Dedication. The organizations responsible for generating and funding this dataset make no representations of any kind including, but not limited to the warranties of merchantability or fitness for a particular use, nor are any such warranties to be implied with respect to the data. Although every effort has been made to ensure the accuracy of information, errors may be reflected in data supplied. The user must be aware of data conditions and bear responsibility for the appropriate use of the information with respect to possible errors.

Checklist

Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.

  1. Add relevant examples.
  2. [N/A] Add relevant counterexamples.
  3. Update any counterexamples that became obsolete. For example, if a counterexample uses property A but is not intended to test property A's validity, and you made a schema change that invalidates property A in that counterexample, fix the counterexample to align it with your schema change.
  4. Update in-schema documentation using plain English written in complete sentences, if an update is required.
  5. Update Docusaurus documentation, if an update is required.
  6. Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.

Documentation Website

Update the hyperlink below to put the pull request number in.

Docs preview for this PR.

@vcschapp
Copy link
Collaborator

We should try to boot this PR up and aim for September or October release. Not rushing due to GA and post-GA freeze but should be in!

schema/base/bathymetry.yaml Outdated Show resolved Hide resolved
- "$ref": ../defs.yaml#/$defs/propertyContainers/cartographyContainer
required:
- elevation
properties:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Should we add a relationship property to reference the feature to the water body it is providing the bathymetry for?
  2. Should we add a property to specify what type of water body it pertains to?

I'm not too sure about the second one, but adding it for discussion. Might be useful to know if something is ocean or inland at least?

For the first one, the ID reference, it would only pertain to "things that exist in the base theme" - we don't have features for ocean water - so it would be optional.

Just throwing out ideas, but we might imagine something like:

---
id: foo
properties:
  theme: base
  type: bathymetry
  depth: 100
  water_location: inland  # Can be "ocean" or "inland"
  water_id: bar           # Omit if there's no matching water feature, otherwise this is ID of a base/water feature

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

water_location might be useful, but not sure how we can relate them to water bodies since the cross cut so many?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they all cross-cut? I got the impression some features were for specific lakes?

jwass and others added 12 commits September 7, 2024 08:22
Fix counterexamples that were failing due to the old names
schema present, not due to their original reason for failing.

This also eliminates "local" as an option for a language

Addresses #265
OvertureMaps/schema-wg#151

This is a commit by vcschapp@ that builds on Ola's work from the above-
referenced issue. There are two changes to the schema:

1. Road "width" moves under the "road" property.
2. Road "width" is now linearly-referenced.

The following are changes from Ola's previous work:

1. In keeping with our Parquet compatibility and tooling compatibility
   drive, there is no option for a scalar value for "width": it must
   now always be a non-empty array of rules.
2. I moved "width" under "road" because it's not obvious that it's a
   generalized property even for all types of segment, let alone across
   Overture, especially with the LR facet.
This commit switches properties and enumerators from `camelCase` naming
to `snake_case` naming.

The purpose is to improve compatibility with SQL based tools. Because
SQL uses case-insensitive identifiers for historical reasons, SQL-based
tools cause problems and information loss with camel-casing because they
tend to treat all identifiers as if they were alllowercase or ALLCAPS.

In the Overture Schema Task Force meeting of 2024-02-07, the task force
decided to adopt the snake_case proposal:

OvertureMaps/schema-wg#272

The proposal originated in Jake's Schema Friction discussion document
on the Overture Confluence:

https://wiki.overturemaps.org/x/SQGAAQ

While we believe that snake_case is slightly unconventional, and dare I
(Vic) say also more unsightly in the JSON context, we feel that for SQL
compatibility reasons, the pros of changing outweigh the cons.
jenningsanderson and others added 25 commits September 7, 2024 08:26
add leisure:recreation_ground
Logic for volcanoes to turn into mountains
adding landuse for debugging, too
… Also adding missing tags to published collection of tags to be used for debugging purposes
…ema repo (#158)

* bare bones reference docs for divisions

* New header

Removing GERS and updating header

* remove everything but reference docs

* Update index.mdx

Add the slug for root

* Fixing longtime react errors

* Fixing react errors

* Fix broken links

* brief intro text

* add link

---------

Co-authored-by: Jennings Anderson <[email protected]>
One of the lines in the categories list is missing an end bracket. I've corrected it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.