[~] Disable Rails/BulkChangeTable as it conflicts with strong_migrations
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It conflicts with strong_migrations suggestions. For instance, the following code reports an offense: ``` add_column :foo, :bar, :string add_column :foo, :baz, :string ``` The above is suggested to be written instead as: ``` change_table :foo, bulk: true do |t| t.string :bar t.string :baz end ``` Which in turn is not supported with strong_migrations and raises an error when trying to execute the migration: https://github.com/ankane/strong_migrations?tab=readme-ov-file#assuring-safety > Certain methods like execute and change_table cannot be inspected and > are prevented from running by default. Make sure what you’re doing is > really safe and use this pattern.
marikrebega
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It conflicts with strong_migrations suggestions. For instance, the
following code reports an offense:
The above is suggested to be written instead as:
Which in turn is not supported with strong_migrations and raises an
error when trying to execute the migration:
https://github.com/ankane/strong_migrations?tab=readme-ov-file#assuring-safety