ROU-4776: adding ability to change google maps version #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add new APIs to allow changing the version of Google Maps.
Context
Google Maps scripts cannot be hosted, and need to be imported from their CDN. If a version is not specified Google loads always the most recent stable version of the library. This was causing errors or warnings to appear, as neither the OutSystems R&D nor the developer using the component, control when the update was done.
To avoid this problems, the version of the Google Maps scripts being loaded was locked to a specific version (currently 3.57).
What was happening
What was done
OutSystems.Maps.MapAPI.ProviderLibrary.GetVersion(#PROVIDERNAME#)
OutSystems.Maps.MapAPI.ProviderLibrary.SetVersion(#PROVIDERNAME#, #VERSION#, #FORCE_REFRESH#)
GoogleMapsVersion
to allow the developer to change the versionTest Steps
OutSystems.Maps.MapAPI.ProviderLibrary.GetVersion('Google')
3.55
)Checklist