Skip to content

Add OnConsoleMessage from browser #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ykarpeev wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add OnConsoleMessage from browser #351

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90aed8b
add OnConsoleMessage from browser
ykarpeev Sep 3, 2024
983bcb1
rename OnConsoleMessage to ConsoleMessageEmitted
ykarpeev Sep 4, 2024
e31e5fb
recreate ConsoleMessageEventArgs, ConsoleMessageEventHandler and CefL…
ykarpeev Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions WebViewControl/WebView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ public partial class WebView : IDisposable {
public event Action TitleChanged;
public event UnhandledAsyncExceptionEventHandler UnhandledAsyncException;
public event Action</*url*/string> PopupOpening;
public event ConsoleMessageEventHandler OnConsoleMessage;

@joaompneves joaompneves Sep 3, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the ConsoleMessageEventHandler

Also OnConsoleMessage should be ConsoleMessageEmitted

@ykarpeev ykarpeev Sep 4, 2024

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I changed OnConsoleMessage to ConsoleMessageEmitted.

For me Xilium.CefGlue.Common.Events has ConsoleMessageEventHandler and there is an import to it in WebView.cs

using Xilium.CefGlue.Common.Events;

Would it be recommended to recreate it in the webview project? Thank you.

@joaompneves joaompneves Sep 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Yes. The webview doesn't/shouldn't expose anything from CefGlue

@ykarpeev ykarpeev Sep 6, 2024

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I think I got everything properly recreated in the webview control in latest commit.


internal event Action Disposed;
internal event JavascriptContextReleasedEventHandler JavascriptContextReleased;
Expand Down Expand Up @@ -129,6 +130,8 @@ private void Initialize() {
chromium.JavascriptContextReleased += OnJavascriptContextReleased;
chromium.JavascriptUncaughException += OnJavascriptUncaughException;
chromium.UnhandledException += (o, e) => ForwardUnhandledAsyncException(e.Exception);
chromium.ConsoleMessage += (o, e) => OnConsoleMessage.Invoke(o, e);


chromium.RequestHandler = new InternalRequestHandler(this);
chromium.LifeSpanHandler = new InternalLifeSpanHandler(this);
Expand Down