Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary inter process communication (IPC) #170

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert changes in CefBinaryValue
Piotr Bala authored and Piotr Bala committed Oct 8, 2024
commit 07b0e4adf7d15225df6a5b914144117fe1533928
2 changes: 1 addition & 1 deletion CefGlue/Classes.Interfaces/ICefBinaryValue.cs
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ public interface ICefBinaryValue : IDisposable
long Size { get; }

ICefBinaryValue Copy();
long GetData(Span<byte> buffer, long bufferSize, long dataOffset);
long GetData(byte[] buffer, long bufferSize, long dataOffset);
bool IsEqual(ICefBinaryValue that);
bool IsSame(ICefBinaryValue that);
byte[] ToArray();
4 changes: 2 additions & 2 deletions CefGlue/Classes.Proxies/CefBinaryValue.cs
Original file line number Diff line number Diff line change
@@ -96,9 +96,9 @@ public long Size
/// Read up to |buffer_size| number of bytes into |buffer|. Reading begins at
/// the specified byte |data_offset|. Returns the number of bytes read.
/// </summary>
public long GetData(Span<byte> buffer, long bufferSize, long dataOffset)
public long GetData(byte[] buffer, long bufferSize, long dataOffset)
{
if (buffer.Length < dataOffset + bufferSize) throw new ArgumentOutOfRangeException("dataOffset");
if (buffer.LongLength < dataOffset + bufferSize) throw new ArgumentOutOfRangeException("dataOffset");

fixed (byte* buffer_ptr = buffer)
{