-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MBCn with 5days-OddWindow #79
Open
coxipi
wants to merge
11
commits into
main
Choose a base branch
from
mbcn_5d
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's about 5 times as faster, as expected (well, I just showed the training, but you get it) from xclim.testing import open_dataset
import xsdba
ds = open_dataset('sdba/ahccd_1950-2013.nc')
da = xsdba.stack_variables(ds)
group = xsdba.Grouper("5D", window=7)
ADJ = xsdba.MBCn.train(ref=da,hist=da,base_kws=dict(group=group))
ADJ.ds.af_q.compute()
# >>> 8.6 s
group = xsdba.Grouper("time.dayofyear", window=31)
ADJ = xsdba.MBCn.train(ref=da,hist=da,base_kws=dict(group=group))
ADJ.ds.af_q.compute()
# >>> 41.4 s ~ 5x slower, as expected |
5 tasks
In my tests, I had also created a specific class DQM_gpies to be able to compute DQM like MBCn, and use directly the 5d7w time grouping. I could release this version, but maybe we should instead investigate in a solution to accept 5d7w grouping in map_groups. I have a feeling it's gonna be rough though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
No
Other information:
This doesn't respect the logic of
Grouper
, but to activate this functionality, I pass aGrouper("5D", window=7)
. I think only time, time.season, time.month, time.dayofyear would be allowed as strings in a proper implementation ("The usual grouping name as xarray understands it. Ex: "time.month" or "time".") To allow more complex group, I guess we would need to accept Pandas object or something.Since MBCn doesn't currently use map_groups, implementing this hack was relatively easy.
This is also thought specifically for a 365-day calendar, that 5 is a factor of 365 (5*73).