Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "xsdba" in docs and option #72

Merged
merged 10 commits into from
Feb 18, 2025
Merged

Use "xsdba" in docs and option #72

merged 10 commits into from
Feb 18, 2025

Conversation

coxipi
Copy link
Contributor

@coxipi coxipi commented Feb 10, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Changes in docs / global options to reflect xsdba is its own module

Does this PR introduce a breaking change?

Yes, it removes SDBA_ENCODE_CF
Renames XSDBA_EXTRA_OUTPUT to EXTRA_OUTPUT

Other information:

@coxipi coxipi requested a review from Zeitsperre February 11, 2025 16:10
@coxipi
Copy link
Contributor Author

coxipi commented Feb 11, 2025

@Zeitsperre minor changes, should be fine once coveralls issue is solved

Copy link
Contributor

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@github-actions github-actions bot added the docs label Feb 11, 2025
@coxipi
Copy link
Contributor Author

coxipi commented Feb 17, 2025

Once the tests pass, this is good to go

@coveralls
Copy link

Coverage Status

coverage: 73.962% (-0.05%) from 74.011%
when pulling 1574cb9 on naming_conventions
into 5ca6552 on main.

@coxipi
Copy link
Contributor Author

coxipi commented Feb 18, 2025

Many docstrings have been converted automatically given the flexibility given to avoid the problem with the Indicator class?

@coxipi coxipi merged commit 29423d8 into main Feb 18, 2025
14 checks passed
@coxipi coxipi deleted the naming_conventions branch February 18, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants