Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cookiecutter template, minor fixes #71

Merged
merged 11 commits into from
Feb 17, 2025
Merged

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented Feb 6, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Updates the cookiecutter template
  • Python and GitHub Actions version updated
  • Now using advanced CodeQL configuration
  • New pre-commit hooks vulture (find dead code), codespell (grammatical errors), zizmor (workflow security), and gitleaks (token commit prevention).
  • Corrected some spelling and security issues
  • Removed the Python netcdf4 package.

Does this PR introduce a breaking change?

Nope.

Other information:

mypy is staged but not configured. This will require a significant amount of effort to adopt and adhere to.

@Zeitsperre Zeitsperre requested a review from coxipi February 6, 2025 17:29
@Zeitsperre Zeitsperre self-assigned this Feb 6, 2025
@Zeitsperre
Copy link
Contributor Author

@coxipi Do you happen to know what could be the cause of problems here? I'm seeing segfaults (?!) on conda builds.

Copy link
Contributor

@coxipi coxipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks goodf

@Zeitsperre Zeitsperre merged commit 23eb025 into main Feb 17, 2025
15 checks passed
@Zeitsperre Zeitsperre deleted the cookiecutter-update branch February 17, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants