Add no-input options for make-admin-user command
#469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-kelp
reviewed
Jun 30, 2024
Comment on lines
+59
to
+79
| ): | ||
| """Add confirmed administrator account.""" | ||
| while True: | ||
| username = input("Username: ") | ||
| username = supplied_username or input("Username: ") | ||
| user = User.by_username(username).one_or_none() | ||
| if user: | ||
| print("Username is already in use") | ||
| else: | ||
| break | ||
|
|
||
| while True: | ||
| email = input("Email: ") | ||
| email = supplied_email or input("Email: ") | ||
| user = User.by_email(email).one_or_none() | ||
| if user: | ||
| print("Email address already in use") | ||
| else: | ||
| break | ||
|
|
||
| while True: | ||
| password = getpass("Password: ") | ||
| password_again = getpass("Type your password again: ") | ||
| password = supplied_password or getpass("Password: ") | ||
| password_again = supplied_password or getpass("Type your password again: ") |
There was a problem hiding this comment.
Could we put the while loops in a if not supplied_... block? I'm a little worried that if an existing email/username is supplied somehow that we'll fall into an infinite loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #221
This PR adds some CLI options for the
make-admin-usercommand which allows the username, email, and password of the admin account to be specified. This makes it easier to run the command without prompting for any inputs, as is done in thejust fresh-startrecipe.Notes for Deployment
None
Screenshots (if appropriate)
N/A
Tests and linting
Run
just fresh-startlocally and note how the admin creation account step!I have rebased my changes on
mainjust lintpassesjust testpasses