Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker's "compose" command rather than docker-compose #467

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AetherUnbound
Copy link
Collaborator

Description of Changes

Fixes #463 (at least for the justfile which is what we primarily use). This changes calls from the docker-compose plugin to docker's compose command directly (docker compose). I also removed the version argument which was throwing these warnings:

$ j build
docker compose --file=docker-compose.yml --file=docker-compose.dev.yml build
WARN[0000] /home/madison/git/OpenOversight/docker-compose.yml: `version` is obsolete 
WARN[0000] /home/madison/git/OpenOversight/docker-compose.dev.yml: `version` is obsolete 

Notes for Deployment

None

Screenshots (if appropriate)

N/A

Tests and linting

To test, try running just build locally and make sure you don't see the warnings and that the containers should be built appropriately.

  • I have rebased my changes on main

  • just lint passes

  • just test passes

@AetherUnbound AetherUnbound added enhancement New feature or request docker/env Docker, environment, or CI changes labels Jun 26, 2024
@AetherUnbound AetherUnbound requested a review from a team as a code owner June 26, 2024 04:51
Copy link
Collaborator

@sea-kelp sea-kelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker/env Docker, environment, or CI changes enhancement New feature or request
Projects
Status: 📋 Backlog
Development

Successfully merging this pull request may close these issues.

Change docker-compose to docker compose
2 participants