Fix issue where carousel controls were no longer showing up #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2024
|
The only issue with this is that on darker photos, it becomes difficult to tell that there are carousel arrows at all 😞 |
AetherUnbound
approved these changes
Feb 12, 2024
|
@AetherUnbound: The arrows are built into the version of Bootstrap we're using unfortunately. Let's circle back to this after the re-design |
michplunkett
pushed a commit
to lucyparsons/OpenOversight
that referenced
this pull request
Feb 12, 2024
<!-- New Contributor? Welcome! We recommend you check your privacy settings, so the name and email associated with the commits are what you want them to be. See the contribution guide at https://github.com/lucyparsons/OpenOversight/blob/develop/CONTRIB.md#recommended-privacy-settings for more infos. Also make sure you have read and abide by the code of conduct: https://github.com/lucyparsons/OpenOversight/blob/develop/CODE_OF_CONDUCT.md If this pull request is not ready for review yet, please submit it as a draft. Please write your PR name in the present imperative tense. Examples of that tense are: "Fix issue in the dispatcher where…", "Improve our handling of…", etc. --> ## Description of Changes Copied over from OrcaCollective#409 The carousel controls are not showing up. This was caused by a commit that changed `paths` to `face_paths` https://github.com/lucyparsons/OpenOversight/pull/1070/files#diff-cb0d1be5137549bba7d2d657912ea708497d8a757e0623cb76d9d5557fe484e5 But the line controlling whether we show carousel controls is still using `paths`. https://github.com/OrcaCollective/OpenOversight/blob/7bf658c8d431d2db12154ba5c90017d46f19cf14/OpenOversight/app/templates/partials/officer_faces.html#L21 This commit fixes this issue. ## Notes for Deployment N/A ## Screenshots (if appropriate) ## Tests and Linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The carousel controls are not showing up.
This was caused by a commit that changed
pathstoface_pathshttps://github.com/lucyparsons/OpenOversight/pull/1070/files#diff-cb0d1be5137549bba7d2d657912ea708497d8a757e0623cb76d9d5557fe484e5
But the line controlling whether we show carousel controls is still using
paths.OpenOversight/OpenOversight/app/templates/partials/officer_faces.html
Line 21 in 7bf658c
This commit fixes this issue.
Notes for Deployment
None!
Screenshots (if appropriate)
Tests and linting
I have rebased my changes on
mainjust lintpassesjust testpasses