Fix link edit/delete buttons showing when not logged in #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
michplunkett
pushed a commit
to lucyparsons/OpenOversight
that referenced
this pull request
Jan 5, 2024
## Fixes issue Fixes #1085 ## Description of Changes This is a cherry-pick of OrcaCollective#403 --- Currently, the link edit and delete buttons show up on the officer page when visiting as an anonymous user. (see: https://openoversight.com/officers/83835) This is NOT a security issue as the user is asked to log in after clicking the link but may be confusing to users. ## Notes for Deployment None! ## Screenshots (if appropriate) N/A ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
michplunkett
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Currently, the link edit and delete buttons show up on the officer page when visiting as an anonymous user. (see: https://openoversight.tech-bloc-sea.dev/officers/96)
This is NOT a security issue as the user is asked to log in after clicking the link but may be confusing to users.
Notes for Deployment
None!
Screenshots (if appropriate)
N/A
Tests and linting
I have rebased my changes on
mainjust lintpassesjust testpasses