Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tests #73

Merged
merged 15 commits into from
Jan 31, 2024
Merged

Fix Tests #73

merged 15 commits into from
Jan 31, 2024

Conversation

harveysanders
Copy link
Contributor

@harveysanders harveysanders commented Jan 29, 2024 •
edited by ptbarnum4
Loading

  • Update fs-extra
  • Add devcontainer.json
  • Fix clc usage;
  • Add prettierrc
  • Remove resolutions for graceful-fs in package.json

@harveysanders harveysanders linked an issue Jan 29, 2024 that may be closed by this pull request
Remove svn dependency #72
Closed
3 tasks
ptbarnum4
ptbarnum4 reviewed Jan 29, 2024
View reviewed changes
ptbarnum4
ptbarnum4 reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@ptbarnum4 ptbarnum4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good so far!

ptbarnum4
ptbarnum4 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@ptbarnum4 ptbarnum4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great! look at this sweet passing checkmark!
Screenshot 2024-01-30 at 3 50 22 PM

at some point I think the test files should be renamed to (*.test.js or *.spec.js) for clarity

@harveysanders harveysanders marked this pull request as ready for review January 30, 2024 23:00
@harveysanders harveysanders mentioned this pull request Jan 30, 2024
Closed
@harveysanders harveysanders merged commit a6ca015 into master Jan 31, 2024
1 check passed
@harveysanders harveysanders deleted the 72-remove-svn-dependency branch January 31, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptbarnum4 ptbarnum4 ptbarnum4 approved these changes

@gregthompson27 gregthompson27 Awaiting requested review from gregthompson27

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove svn dependency
2 participants
@harveysanders @ptbarnum4