atapi_pt_helper: various refactoring/cleanup/fixes

* Enabled -Wall -Werror CFLAGS. * Removed unused version bits that caused (error) warnnings. * Dropped shared memory usage, all that logic is in the qemu & xenstore / toolstack side. * Fixed buggy fnctl() usage. * Rewrote atapi-pt-v4v protocol using definitions in atapi_pt_v4v.h. * Enforce stricter usage of SG_IO. * Added lots of error checking, eliminating some potential vulnerabilities in the APIs. * Made logging more consistent with atapi-pt on qemu side. * Use syslog for logging instead of stderr. OXT-215 Signed-off-by: Chris Patterson <[email protected]>
OpenXT · Apr 8, 2015 · 89d17d5 · 89d17d5
1 parent 623265c
commit 89d17d5
Show file tree

Hide file tree

Showing 4 changed files with 659 additions and 351 deletions.
diff --git a/atapi_pt_helper/src/Makefile.am b/atapi_pt_helper/src/Makefile.am
@@ -34,7 +34,7 @@
 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 #
 
-
+CFLAGS = -Wall -Werror
 CPROTO=cproto
 INCLUDES = ${X_CFLAGS}