Fix: fix cicd builds #1154

DawidWesierski4 · 2025-05-16T13:00:09Z

CiCd setup is broken due to the actions failing to build the project. Fix via switching building to the script.

Sakoram · 2025-05-19T06:25:59Z

Please change the"*e810_driver" name to "*ice_driver". The ice driver supports more models from 800 series; like e825 and e830.

zLukas · 2025-05-20T08:59:41Z

.github/workflows/ubuntu_build.yml

@@ -1,4 +1,4 @@
-name: Base Build
+name: Ubuntu build


revoke changes in file/job name

well yes
Base build doesn't tell the user on the website nothing really
We will implement Rockyos support and then we will have on the main readme
Rockyos build
aaaand base build ?

therea re other names under base build, not only this, and we also agreed to keed the same naming convection between BCS/MTL/MCM CI pipelines

DawidWesierski4 · 2025-05-20T09:05:16Z

.github/workflows/ubuntu_build.yml

+      - name: Install the build dependencies
+        env:
+          BUILD_AND_INSTALL_DPDK: 1
+          BUILD_E810_DRIVER: 1
+          # ICE driver installation is disabled (not supported in GitHub Actions)
+          BUILD_AND_INSTALL_ICE_DRIVER: 0


This i plan to trigger via path_filters.yml
we can set them dynamically so this job could replace
build ffmpeg
build eBPF XDP
and all others

CiCd setup is broken due to the actions failing to build the project. Fix via switching building to the script.

Mionsz · 2025-05-21T11:33:24Z

.github/scripts/setup_environment.sh

+
+if [ "$SETUP_ENVIRONMENT" == "1" ]; then


Allow sourcing the script and exec only if there is such intent.

Suggested change

if [ "$SETUP_ENVIRONMENT" == "1" ]; then

# Allow sourcing of the script.

if [[ "${BASH_SOURCE[0]}" == "${0}" ]]

then

if [ "$SETUP_ENVIRONMENT" == "1" ]; then

Mionsz · 2025-05-21T11:38:34Z

.github/scripts/setup_environment.sh

+# Copyright 2025 Intel Corporation
+


Get the path to the script dir and repository root folder to be caller agnostic:

Suggested change

# Copyright 2025 Intel Corporation

# Copyright 2025 Intel Corporation

REPO_DIR="$(readlink -f "$(dirname -- "${BASH_SOURCE[0]}")/../..")"

They are ?
"${BASH_SOURCE[0]}")/../..")" does exactly that
It's dependent on the position of the script, so even when source,d this will point to the position of the soruced script

I think this is the most foolproof way of doing that as dirname $0 is dependent on if the script was sourced or not

But i am open to suggestions
i don't like using absolute paths, usually as relative paths will work no matter the environment IMO

please correct me if I'm wrong ( ╹ -╹)?

Mionsz · 2025-05-21T11:41:55Z

.github/workflows/ubuntu_build.yml

    steps:
      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-


new line between calls.

Mionsz · 2025-05-21T11:43:31Z

.github/workflows/ubuntu_build.yml

+    env:
+      SETUP_ENVIRONMENT: 0
+      BUILD_AND_INSTALL_EBPF_XDP: 0
+      BUILD_AND_INSTALL_DPDK: 0
+      BUILD_ICE_DRIVER: 0 # Only for CICD action builds
+      BUILD_AND_INSTALL_ICE_DRIVER: 0


this refers to changes:, so for readability should be before steps (steps 99% of time should be the last in current yaml tree.

Mionsz · 2025-05-21T11:44:27Z

.github/workflows/ubuntu_build.yml

 jobs:
  changes:
    runs-on: ubuntu-latest
    permissions:
      pull-requests: read
    outputs:
-      changed: ${{ steps.filter.outputs.ubuntu_build == 'true' }}
+      base: ${{ steps.filter.outputs.ubuntu_build == 'true' }}
+      afxdp_build: ${{ steps.filter.outputs.afxdp_build == 'true' }}
    steps:


Move env from end to this place for easy to understand flow:

Suggested change

steps:

env:

SETUP_ENVIRONMENT: 0

BUILD_AND_INSTALL_EBPF_XDP: 0

BUILD_AND_INSTALL_DPDK: 0

BUILD_ICE_DRIVER: 0 # Only for CICD action builds

BUILD_AND_INSTALL_ICE_DRIVER: 0

steps:

Mionsz · 2025-05-21T11:56:01Z

.github/workflows/ubuntu_build_skip_gtest.yml

@@ -25,7 +25,6 @@ jobs:
      changed: ${{ steps.filter.outputs.linux_gtest == 'true' }}
    steps:
      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-


new line between steps

Mionsz · 2025-05-21T11:56:25Z

script/build_dpdk.sh

+	ninja -C build
+	cd build
+	sudo ninja install
+fi


new line at the end of script

Mionsz · 2025-05-21T11:56:40Z

script/build_ebpf_xdp.sh

+	cd lib/libbpf/src
+	make
+	sudo make install
+fi


new line at the end of script

Mionsz · 2025-05-21T12:09:23Z

script/build_ebpf_xdp.sh

+
+	if [ ! -d "xdp-tools" ]; then
+		echo "Clone XDP source code"
+		git clone --recurse-submodules https://github.com/xdp-project/xdp-tools.git


Use instead:

. "./common.sh" git_download_strip_unpack "xdp-project/xdp-tools" "main" "${script_folder}/xdp-tools" git_download_strip_unpack ""libbpf/libbpf"" "main" "${script_folder}/xdp-tools/lib/libbpf"

DawidWesierski4 requested review from Sakoram, skolelis and Falron98 as code owners May 16, 2025 13:00

DawidWesierski4 force-pushed the make_cicd_usable branch 27 times, most recently from c52c450 to a920d30 Compare May 16, 2025 15:48

DawidWesierski4 force-pushed the make_cicd_usable branch 5 times, most recently from f9ea61d to 055340a Compare May 16, 2025 16:26

DawidWesierski4 force-pushed the make_cicd_usable branch 8 times, most recently from dd543d1 to 6f8954d Compare May 19, 2025 13:05

zLukas requested changes May 20, 2025

View reviewed changes

DawidWesierski4 commented May 20, 2025

View reviewed changes

DawidWesierski4 force-pushed the make_cicd_usable branch 7 times, most recently from c429c71 to 0137345 Compare May 21, 2025 06:39

Fix: fix cicd builds

ae75162

CiCd setup is broken due to the actions failing to build the project. Fix via switching building to the script.

DawidWesierski4 force-pushed the make_cicd_usable branch from 0137345 to ae75162 Compare May 21, 2025 07:24

Mionsz reviewed May 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: fix cicd builds #1154

Fix: fix cicd builds #1154

Uh oh!

DawidWesierski4 commented May 16, 2025

Uh oh!

Sakoram commented May 19, 2025 •

edited

Loading

Uh oh!

zLukas May 20, 2025

Uh oh!

DawidWesierski4 May 20, 2025

Uh oh!

zLukas May 22, 2025

Uh oh!

DawidWesierski4 May 20, 2025

Uh oh!

Mionsz May 21, 2025

Uh oh!

Mionsz May 21, 2025

Uh oh!

DawidWesierski4 May 22, 2025 •

edited

Loading

Uh oh!

Mionsz May 21, 2025

Uh oh!

Mionsz May 21, 2025

Uh oh!

Mionsz May 21, 2025

Uh oh!

Mionsz May 21, 2025

Uh oh!

Mionsz May 21, 2025

Uh oh!

Mionsz May 21, 2025

Uh oh!

Mionsz May 21, 2025

Uh oh!

Uh oh!

		steps:
		- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

Fix: fix cicd builds #1154

Are you sure you want to change the base?

Fix: fix cicd builds #1154

Uh oh!

Conversation

DawidWesierski4 commented May 16, 2025

Uh oh!

Sakoram commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DawidWesierski4 May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Sakoram commented May 19, 2025 •

edited

Loading

DawidWesierski4 May 22, 2025 •

edited

Loading