Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pseudo cross-browser styling for readonly Auth Strategies #1734

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Pseudo cross-browser styling for readonly Auth Strategies #1734

merged 1 commit into from
Aug 17, 2020

Conversation

Martii
Copy link
Member

@Martii Martii commented Aug 17, 2020

  • Using this as a subtle notice that a strategy has been disabled in case someone isn't watching dev
  • Fx still doesn't support styling unfortunately ( https://bugzilla.mozilla.org/show_bug.cgi?id=910022 ) so plain disable it. Should cut down on b/w but also possible Code testing increase with visible delineation in dev.

Post #1174 and reminder-ed in #1189 ... related to #1732 #1733

@Martii
Pseudo cross-browser styling for readonly Auth Strategies
9dc091a 
* Using this as a subtle notice that a strategy has been disabled in case someone isn't watching dev
* Fx still doesn't support styling unfortunately *( https://bugzilla.mozilla.org/show_bug.cgi?id=910022 )* so plain disable it. Should cut down on b/w but also possible Code testing increase with visible delineation in dev.

Post OpenUserJS#1174 and reminder-ed in OpenUserJS#1189 ... related to OpenUserJS#1732 OpenUserJS#1733
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Aug 17, 2020
@Martii Martii merged commit ff1e6cf into OpenUserJS:master Aug 17, 2020
@Martii Martii deleted the pseudoStyleLoginReadOnly branch August 17, 2020 09:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii