Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify dev setup #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clarify dev setup #61

wants to merge 1 commit into from

Conversation

kjschiroo
Copy link
Collaborator

The README isn't totally clear about what is running on your local
machine vs what is running on a docker instance. Adding some more
documentation that will hopefully make that a bit more clear. As a
little side edition this also pins the version of webpack being used to
the ancient one that was initially used when the client was being built.

The README isn't totally clear about what is running on your local
machine vs what is running on a docker instance. Adding some more
documentation that will hopefully make that a bit more clear. As a
little side edition this also pins the version of webpack being used to
the ancient one that was initially used when the client was being built.
@kjschiroo
Copy link
Collaborator Author

Should address #60

@eebbesen
Copy link
Contributor

eebbesen commented Nov 3, 2019

@kjschiroo can you try to over-clarify, especially on prerequisites and versions that may be in play? On a fresh Ubuntu VM, os x and an existing Ubuntu box I'm still having issues with these instructions. Admittedly I'm not familiar with Python projects, but I seem to be having more luck with virtual environments, etc.

Please see https://gist.github.com/eebbesen/21141d8cc8f46171ab26a59797383d3d

@kjschiroo
Copy link
Collaborator Author

kjschiroo commented Nov 3, 2019

@eebbesen Before running python manage.py migrate did you run pipenv shell? I think pipenv usually leaves some decoration in the command prompt to show the user is in a virtual environment and I'm not seeing it there. This makes me think that you might have accidentally run the command outside of the virtual environment. If you did run pipenv shell before could you also include the results of which python and pip freeze?

@eebbesen
Copy link
Contributor

eebbesen commented Nov 3, 2019

@kjschiroo in addition to the local build issues with pip Docker was running into issues as well. Please have a look at the changes for #62 and let me know if those are appropriate for everyone. I now have the app up and running locally.

In particular I had to remove a line from urls.py...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants