-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent updates to the custom LED theme page include enhanced color pi… #978
Recent updates to the custom LED theme page include enhanced color pi… #978
Conversation
…cker placement options (top, bottom, left, or right) to ensure it never appears off-screen and remains accessible. Additionally, new button layouts for Haute42 (13 & 16 buttons) and DuelPad (16 buttons) have been added to the preview layout options dropdown list.
I have another push coming with some minor updates
new push on the way |
…and Arc browsers. - Changed element size from 450px to 425px for closer alignment with original 400px. - Fixed button overlap in Haute42 13 layout by adjusting A1 button spacing. The A1 button would overlap the A2 button if you made the browser window to narrow.
…less 16 A," and "Stickless 16 B" to avoid vendor liability and eliminate appearance of vendor bias.
Hey @KeyOnTech, thanks for the PR! We appreciate the effort to make things easier while we're reworking the LED system. I've taken a look through the code and tested it out, and here are my notes. Rename layouts to match existing layouts in the Display Configuration page
That last 16 button layout doesn't exist in the Display Configuration currently, so we may want to add that. Probably not a blocker for this PR, but something I'll need to follow up on. Using the gradient feature on the new layouts doesn't quite work This is because the matrices for the new layouts in
Consolidate button arrays into I think the button arrays should be rolled into the Color Picker Placement This feature works fine and I don't see a problem including it. |
…uttonArray to AuxButtons for consistency with MainButtons.
…ain alphabetical order.
…16-button configurations, to align with popular market layouts that I own.
Hey sorry for the delay on replying |
gradient button selector not working fixed, moving to next issue |
Fixed: Rename layouts to match existing layouts in the Display Configuration page |
…ed sorting to list button layout options alphabetically in dropdowns.
Everything noted has been fixed and updated |
Thanks @KeyOnTech! I'll try to get it reviewed this weekend. |
…has an API rewrite. Button layout and ButtonLayoutRight are now managed via an API, no longer an object in the page file, rendering my previous modifications unnecessary.
Reverted my changes to DisplayConfig.jsx due to a code conflict that has an API rewrite. Button layout and ButtonLayoutRight are now managed via an API, no longer an object in the page file, rendering my previous modifications unnecessary. |
I see a file conflict on the package-lock.json file |
Hey @FeralAI wanted to check in on the updates I made to the color picker screen button layouts and color picker box. I got a comment today and they were experiencing what I was on different browsers I think my minor updates will help. |
I'll jump in on this one and put in my approval. I like the updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! All changes were accounted for and the formatting matches our current web config
Thank You !! I'll look around and see where else I can help on the web configurator. |
Updates to the custom LED theme page include enhanced color picker placement options (top, bottom, left, or right) to ensure it never appears off-screen and remains accessible. Additionally, new button layouts for Haute42 (13 & 16 buttons) and DuelPad (16 buttons) have been added to the preview layout options dropdown list.
updates made to the custom led theme page
users can now select where the color picker will appear top, bottom, left, or right preventing picker appearing off screen and unusable
updates made to the preview layout options drop down list
added Haute42 13 & 16 button layouts
added DuelPad 16 button layout