OIP-draft add exists to UtilityTokenInterface
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO; write specification for cogateway |
benjaminbollen
changed the title
exists to UtilityTokenInterface
benjaminbollen
changed the title
exists to UtilityTokenInterfaceexists to UtilityTokenInterface
|
implemented in mosaic-contracts 0.10.0 |
schemar
approved these changes
Apr 1, 2019
There was a problem hiding this comment.
LGTM 
We should prevent deadlocks as early as possible and this seems to be the place. It is the first time where the target chain knows about the mint intention and the intended recipient.
In my opinion the "Simple Summary" could be made even more "simple".
"Motivation" could be more verbose, maybe.
| @@ -0,0 +1,64 @@ | |||
| --- | |||
| oip: <to be assigned> | |||
| title: <Staking Beneficiary Exists> | |||
There was a problem hiding this comment.
remove brackets when adding actual values that replace the placeholders.
jasonklein
suggested changes
Apr 5, 2019
| <!--A short (~200 word) description of the technical issue being addressed.--> | ||
| By default all addresses exist in the Ethereum specification. For internal | ||
| token economies addresses that are not internal should return `false` | ||
| for `UT.exists`. By including this check on `cogateway.confirmStakingIntent`, |
There was a problem hiding this comment.
confirmStakingIntent has been renamed to confirmStakeIntent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.