-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweet that clip #88
base: master
Are you sure you want to change the base?
Tweet that clip #88
Conversation
still needs validation of text char and duration as well add support for audio converted to video
added support for UI to tweet, and credentials in settings and in app to store twitter API to enable tweet of video, missing tweeting audio as needs to convert audio to video otherwsie API returns error
updated to 1.0.7 version of tweet-that-clip, done a test, seems to work, need to fix the showing of the link and using shell in electron to open in new window. disabled it for now. Also only got it to work in autoEdit electron env for now.
change console.error console.log
…into tweet-that-clip
started integration
altho the caption segmentation algo is a bit clunky, and the included in the srt segment falls short by a few words. needs more tweaks
Does not seem to apply as the button is disabled until the tweet has confirmed to have gone through |
Tested and seems to work fineTested after latest change that makes captions optional.
Some things to think about
To tweet clips to twitter, twitter credentials are required. And in the current setup the user needs to create a twitter app, in The problem is that the app to tweet on user's behalf requires
As far as I understood it, the first two, are part of creating a twitter app, with twitter authentication, while the second two are user specific, and the once that where taken through passportJS in quickQuoteNode express example mentioned above.
Using set in and /set out might not be as straight forward as it could be. Eg it could be connected with selections / highlight instead? Some stuff left to do
|
Leaving a note that with Firebase auth, // Using a redirect.
firebase.auth().getRedirectResult().then(function(result) {
if (result.credential) {
// For accessing the Twitter API.
var token = result.credential.accessToken;
var secret = result.credential.secret;
}
var user = result.user;
});
// Start a sign in process for an unauthenticated user.
var provider = new firebase.auth.TwitterAuthProvider();
firebase.auth().signInWithRedirect(provider); |
There is also this module |
PR for new feature #74
To test before merge
Also check
Tweeting video does not seem to work
To do: