Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweet that clip #88

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

Tweet that clip #88

wants to merge 21 commits into from

Conversation

pietrop
Copy link
Collaborator

@pietrop pietrop commented Feb 11, 2019

PR for new feature #74

To test before merge

  • Tweet video as audio with captions
  • Tweet video as audio without captions <-- Not working
  • Tweet video as video with captions
  • Tweet video as video without captions <-- Not working

Also check

  • What happens if you start tweeting a new clip when another one is still being processed? (should work 🤞 but it might not - tbc)

Tweeting video does not seem to work

To do:

  • update with master

pietrop and others added 14 commits September 9, 2018 19:54
still needs validation of text char and duration as well add support for audio converted to video
added support for UI to tweet, and credentials in settings and in app to store twitter API to enable tweet of video, missing tweeting audio as needs to convert audio to video otherwsie API returns error
updated to 1.0.7 version of tweet-that-clip, done a test, seems to work, need to fix the showing of the link and using shell in electron to open in new window. disabled it for now. Also only got it to work in autoEdit electron env for now.
change console.error console.log
started integration
altho the caption segmentation algo is a bit clunky, and the included in the srt segment falls short by a few words. needs more tweaks
@pietrop
Copy link
Collaborator Author

pietrop commented Mar 27, 2019

  • What happens if you start tweeting a new clip when another one is still being processed? (should work 🤞 but it might not - tbc)

Does not seem to apply as the button is disabled until the tweet has confirmed to have gone through

@pietrop
Copy link
Collaborator Author

pietrop commented Mar 27, 2019

Tested and seems to work fine

Tested after latest change that makes captions optional.

  • Tweet video as audio with captions
  • Tweet video as audio without captions
  • Tweet video as video with captions
  • Tweet video as video without captions

Some things to think about

  • Twitter credentials

To tweet clips to twitter, twitter credentials are required. And in the current setup the user needs to create a twitter app, in quickQuoteNode which used express, user could just log in with their twitter account using passport.js

The problem is that the app to tweet on user's behalf requires

  1. Twitter Consumer Key
  2. Twitter Consumer Secret
  3. Twitter Access Token
  4. Twitter Access Token Secret

As far as I understood it, the first two, are part of creating a twitter app, with twitter authentication, while the second two are user specific, and the once that where taken through passportJS in quickQuoteNode express example mentioned above.

  • The UI for selecting a clip segment might be confusing.

Using set in and /set out might not be as straight forward as it could be. Eg it could be connected with selections / highlight instead?

Screen Shot 2019-03-27 at 22 21 37

Some stuff left to do

  • add, "How To" to user manual
  • update user manual version number to latest version 1.0.19
  • add instructions how to get Twitter credentials for settings

@pietrop
Copy link
Collaborator Author

pietrop commented Feb 1, 2020

Leaving a note that with Firebase auth, firebase.auth.TwitterAuthProvider you can do this and get token and secret

// Using a redirect.
firebase.auth().getRedirectResult().then(function(result) {
  if (result.credential) {
    // For accessing the Twitter API.
    var token = result.credential.accessToken;
    var secret = result.credential.secret;
  }
  var user = result.user;
});

// Start a sign in process for an unauthenticated user.
var provider = new firebase.auth.TwitterAuthProvider();
firebase.auth().signInWithRedirect(provider);

@pietrop
Copy link
Collaborator Author

pietrop commented Feb 1, 2020

There is also this module

oauth-electron-twitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant