Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Building Guide on servers #826

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Building Guide on servers #826

wants to merge 3 commits into from

Conversation

Eufranio
Copy link

No description provided.

@boq
Copy link
Member

boq commented Jun 17, 2017

Oh my, this is going to be tricky...

  1. I'm not planning any new 1.7.10 releases. I haven't fully figured how will it look in 1.10.2 yet (mostly works, but there are few glitches)
  2. As I said in Enhanced Building Guide Cannot Build #755, I don't really know which specific change from Bukkit/Cauldron/Thermos/whatever does that, so I'm not eager to throw out working solution for something less functional (especially without config options).
  3. Tabs vs. spaces

@Eufranio
Copy link
Author

This is not less functional, I've opened this PR just to replace your method with another one that works, and fire events (just like any other mod should fire). This shouldn't have nothing to do with Bukkit/Cauldron/Thermos/whatever, it's just a simple method, it won't change anything in the gameplay, so how am I supposed to make a config option?

@Eufranio
Copy link
Author

Also, I couldn't edit the code correctly because I couldn't import your source to my IDEA (building works fine), so I copy-pasted the class into a random file in my IDE and edited it, then I uploaded this file to github via the web app...

img

@boq
Copy link
Member

boq commented Jun 17, 2017

Ah, I was talking about dropping player information, but I misread that part.

Though you don't restore snapshot on cancelled event.

Also, if it's related to #755, what environments have you tested?

@Eufranio
Copy link
Author

Since I can't compile the code, I couldn't test, I was about to open an issue about the error but you're here now, so...

@boq
Copy link
Member

boq commented Jun 17, 2017

Can't help with Idea (always used Eclipse). Though we are not doing anything special other than subproject for OpenModsLib (which should be supported, since it's standard Gradle feature).

@Eufranio
Copy link
Author

The subproject is there, Gradle build it:

img

I will research a bit and try to find why it isn't working.

@Eufranio
Copy link
Author

I just needed a gradlew setupDecompWorkspace xD

@Eufranio
Copy link
Author

It's now working, but I'm having some problems when the event is cancelled: the for loop will skip the protected block, but will still place it (not restoring)...

@Eufranio
Copy link
Author

Eufranio commented Jun 17, 2017

Fixed, it's now respecting cancelled events, and working on Singleplayer/Mixed (Forge + Bukkit) servers. With this update, you could also make a release of OpenModsLib (the fix you pushed for /dev/null/ is only in OpenModsLib-1.7.10-0.10-snapshot-465, not in the official release as you fixed it later).

@Eufranio
Copy link
Author

@boq

@boq
Copy link
Member

boq commented Jun 21, 2017

Please don't ping.

I appreciate your work, but unless there is a world-breaking bug, I won't do any more 1.7 releases. Please wait for 1.10 merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants