Implement drawString Y offsets #2487
Conversation
| } | ||
|
|
||
| case ControlCodes::Colour::black: | ||
| setTextColour(0); |
There was a problem hiding this comment.
Isn't this just the Colour enum class from Colour.h? Perhaps we can map all of these directly to the enum.
There was a problem hiding this comment.
The vast majority of this code is lifted from drawString but yes should probably make this a table or something.
There was a problem hiding this comment.
checked and no its only a limited subset of colour.h.
There was a problem hiding this comment.
Ah, I see only the three first entries match, indeed. Perhaps we should introduce a separate TextColour enum, then?
| if (loc.x >= rt.x + rt.width) | ||
| return; | ||
|
|
||
| if (loc.x < rt.x - 1280) |
There was a problem hiding this comment.
I think it might be better to use rt.width here, this code is a bit fuzzy and I believe the correct way to handle this is to use the width of the text, if I'm not mistaken this just deals with the case for when text is ever so slightly behind x (0).
There was a problem hiding this comment.
We can deal with this later.
No description provided.