Channel manager #1679
Draft
Channel manager #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeftofZen
force-pushed
the
channelManager
branch
from
411ffd7
to
6554587
Compare
LeftofZen
force-pushed
the
channelManager
branch
from
6554587
to
8de9ec9
Compare
LeftofZen
commented
Oct 15, 2022
| { | ||
| vc.stop(); | ||
| } | ||
| channelManager.stopChannels(ChannelId::vehicle); | ||
| } | ||
|
|
||
| void stopVehicleNoise(EntityId head) |
There was a problem hiding this comment.
move this to channel manager
ZehMatt
reviewed
Oct 15, 2022
|
|
||
| namespace OpenLoco::Audio | ||
| { | ||
| static Channel* makeNewChannel(OpenAL::SourceManager& sourceManager, ChannelId channelId) |
There was a problem hiding this comment.
Best to use unique_ptr, this is currently leaking.
There was a problem hiding this comment.
yeah I will, still trying to figure out why vehicle sounds aren't playing atm, then will fix the memory issues
ZehMatt
reviewed
Oct 15, 2022
| @@ -4,16 +4,15 @@ | |||
|
|
|||
| namespace OpenLoco::Audio | |||
| { | |||
| class VehicleChannel | |||
| class VehicleChannel : public Channel | |||
There was a problem hiding this comment.
In my opinion its best to move out vehicle specific code out entirely, the audio code should be unaware of such things, the vehicle only updates the channel parameters so it's probably best to have that with the vehicle code and not here.
There was a problem hiding this comment.
agreed, I'll look at including that in my refactor here
LeftofZen
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more well-defined mechanism between code asking to play audio, channels, and openal