Add fixture eurolite/tmh-w63
#4464
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
added
new-fixture
Export files validity(Output of test script Test the exported files of selected fixtures against the plugins' export tests. ✔️ eurolite / tmh-w63: d-light / attributes-correctness
✔️ eurolite / tmh-w63: dmxcontrol3 / channel-numbers
✔️ eurolite / tmh-w63: dragonframe / json-schema-conformity
✔️ eurolite / tmh-w63: millumin / json-schema-conformity
❌ eurolite / tmh-w63: qlcplus_4.12.2 / fixture-tool-validation
❌ eurolite / tmh-w63: qlcplus_4.12.2 / xsd-schema-conformity
|
kengruven
reviewed
Dec 6, 2024
| { | ||
| "$schema": "https://raw.githubusercontent.com/OpenLightingProject/open-fixture-library/master/schemas/fixture.json", | ||
| "name": "TMH-W63", | ||
| "categories": ["Moving Head"], |
There was a problem hiding this comment.
Suggested change
| "categories": ["Moving Head"], | |
| "categories": ["Moving Head", "Color Changer"], |
I'd add "Wash", too, if that were a possibility.
| "modelId": 0 | ||
| }, | ||
| "physical": { | ||
| "power": 63, |
There was a problem hiding this comment.
Suggested change
| "power": 63, | |
| "power": 100, |
| "https://www.manualslib.com/manual/3276100/Eurolite-Led-Tmh-W63.html" | ||
| ], | ||
| "productPage": [ | ||
| "https://www.thomann.de/de/eurolite_tmh_w63_moving_head_zoom_wash.htm?msclkid=f89005c80db9118b5b3f6298ade83e6b&utm_source=bing&utm_medium=cpc&utm_campaign=Shopping%20DE&utm_term=4576579731227728&utm_content=LI%20-%20Licht" |
There was a problem hiding this comment.
Suggested change
| "https://www.thomann.de/de/eurolite_tmh_w63_moving_head_zoom_wash.htm?msclkid=f89005c80db9118b5b3f6298ade83e6b&utm_source=bing&utm_medium=cpc&utm_campaign=Shopping%20DE&utm_term=4576579731227728&utm_content=LI%20-%20Licht" | |
| "https://www.thomann.de/de/eurolite_tmh_w63_moving_head_zoom_wash.htm" |
Comment on lines
+18
to
+20
| "rdm": { | ||
| "modelId": 0 | ||
| }, |
There was a problem hiding this comment.
Suggested change
| "rdm": { | |
| "modelId": 0 | |
| }, |
Eurolite has an RDM ID, but I see no evidence that this fixture supports RDM, or that its ID is 0.
| }, | ||
| "modes": [ | ||
| { | ||
| "name": "15ch", |
There was a problem hiding this comment.
Suggested change
| "name": "15ch", | |
| "name": "15-channel", |
| "angleEnd": "narrow" | ||
| } | ||
| }, | ||
| "Internal Programm": { |
There was a problem hiding this comment.
Suggested change
| "Internal Programm": { | |
| "Internal Program": { |
Comment on lines
+130
to
+139
| { | ||
| "dmxRange": [16, 128], | ||
| "type": "Generic", | ||
| "comment": "Automatic- Color + Pan/Tilt" | ||
| }, | ||
| { | ||
| "dmxRange": [129, 255], | ||
| "type": "Generic", | ||
| "comment": "Sound-Control" | ||
| } |
There was a problem hiding this comment.
Suggested change
| { | |
| "dmxRange": [16, 128], | |
| "type": "Generic", | |
| "comment": "Automatic- Color + Pan/Tilt" | |
| }, | |
| { | |
| "dmxRange": [129, 255], | |
| "type": "Generic", | |
| "comment": "Sound-Control" | |
| } | |
| { | |
| "dmxRange": [16, 128], | |
| "type": "Effect", | |
| "effectName": "Automatic Color + Pan/Tilt", | |
| "switchChannels": { | |
| "Program Speed / Sound Sensitivity": "Program Speed" | |
| } | |
| }, | |
| { | |
| "dmxRange": [129, 255], | |
| "type": "Effect", | |
| "effectName": "Sound-Control", | |
| "soundControlled": true, | |
| "switchChannels": { | |
| "Program Speed / Sound Sensitivity": "Sound Sensitivity" | |
| } | |
| } |
Comment on lines
+142
to
+149
| "Program Speed": { | ||
| "capability": { | ||
| "type": "EffectSpeed", | ||
| "speedStart": "fast", | ||
| "speedEnd": "slow", | ||
| "comment": "Speed: fast to slow, Sensitivity: low to high" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Suggested change
| "Program Speed": { | |
| "capability": { | |
| "type": "EffectSpeed", | |
| "speedStart": "fast", | |
| "speedEnd": "slow", | |
| "comment": "Speed: fast to slow, Sensitivity: low to high" | |
| } | |
| }, | |
| "Program Speed": { | |
| "type": "EffectSpeed", | |
| "speedStart": "fast", | |
| "speedEnd": "slow" | |
| }, | |
| "Sound Sensitivity": { | |
| "type": "SoundSensitivity", | |
| "soundSensitivityStart": "low", | |
| "soundSensitivityEnd": "high" | |
| } |
| }, | ||
| { | ||
| "dmxRange": [251, 255], | ||
| "type": "Generic", |
There was a problem hiding this comment.
Suggested change
| "type": "Generic", | |
| "type": "Maintenance", |
Comment on lines
+156
to
+170
| { | ||
| "dmxRange": [21, 100], | ||
| "type": "Generic", | ||
| "comment": "Macro-Pan" | ||
| }, | ||
| { | ||
| "dmxRange": [101, 200], | ||
| "type": "Generic", | ||
| "comment": "Macro-Tilt" | ||
| }, | ||
| { | ||
| "dmxRange": [201, 250], | ||
| "type": "Generic", | ||
| "comment": "Macro Pan+Tilt" | ||
| }, |
There was a problem hiding this comment.
Suggested change
| { | |
| "dmxRange": [21, 100], | |
| "type": "Generic", | |
| "comment": "Macro-Pan" | |
| }, | |
| { | |
| "dmxRange": [101, 200], | |
| "type": "Generic", | |
| "comment": "Macro-Tilt" | |
| }, | |
| { | |
| "dmxRange": [201, 250], | |
| "type": "Generic", | |
| "comment": "Macro Pan+Tilt" | |
| }, | |
| { | |
| "dmxRange": [21, 100], | |
| "type": "Effect", | |
| "effectName": "Macro-Pan" | |
| }, | |
| { | |
| "dmxRange": [101, 200], | |
| "type": "Effect", | |
| "effectName": "Macro-Tilt" | |
| }, | |
| { | |
| "dmxRange": [201, 250], | |
| "type": "Effect", | |
| "effectName": "Macro Pan+Tilt" | |
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eurolite/tmh-w63Fixture warnings / errors
Thank you @HerrDerLocken!