Fix links #3551

luc122c · 2023-10-22T17:29:39Z

Fix some links found via #999

The first set have been updated for follow their 301 redirects.
The second set have had their product pages removed so I've used the wayback machine to bring them back.

github-actions · 2023-10-22T17:32:16Z

Plugin export diff

(Output of test script tests/github/export-diff.js.)

You can view your uncommitted changes in plugin exports manually by executing:
$ node cli/diff-plugin-outputs.js -p <plugin-key> [-c <compare-plugin-key>] <fixtures>

🆚 eurolite/led-z-200-tcl: aglight

Changed outputted file aglight_fixture_library.json

--- removed
+++ added
@@ -18,9 +18,9 @@
           "https://www.steinigke.de/de/mpn51918516-eurolite-led-z-200-strahleneffekt.html"
         ],
         "video": [
           "https://www.youtube.com/watch?v=BH7UX8sXT7Y",
-          "https://www.steinigke.de/download/51918516-Video-55873-eurolite-led-z-200-strahleneffekt-de_en_es_fr.flv"
+          "https://www.steinigke.de/download/51918516-Video-55873-eurolite-led-z-200-strahleneffekt-de_en_es_fr.flv/"
         ]
       },
       "physical": {
         "dimensions": [360, 300, 280],

💤 eurolite/led-z-200-tcl: color-chief

Outputted files not changed.

💤 eurolite/led-z-200-tcl: colorsource

Outputted files not changed.

💤 eurolite/led-z-200-tcl: d-light

Outputted files not changed.

💤 eurolite/led-z-200-tcl: dmxcontrol3

Outputted files not changed.

🆚 eurolite/led-z-200-tcl: dragonframe

Changed outputted file eurolite/led-z-200-tcl.json

--- removed
+++ added
@@ -15,9 +15,9 @@
       "https://www.steinigke.de/de/mpn51918516-eurolite-led-z-200-strahleneffekt.html"
     ],
     "video": [
       "https://www.youtube.com/watch?v=BH7UX8sXT7Y",
-      "https://www.steinigke.de/download/51918516-Video-55873-eurolite-led-z-200-strahleneffekt-de_en_es_fr.flv"
+      "https://www.steinigke.de/download/51918516-Video-55873-eurolite-led-z-200-strahleneffekt-de_en_es_fr.flv/"
     ]
   },
   "physical": {
     "dimensions": [360, 300, 280],

💤 eurolite/led-z-200-tcl: ecue

Outputted files not changed.

💤 eurolite/led-z-200-tcl: millumin

Outputted files not changed.

💤 eurolite/led-z-200-tcl: op-z

Outputted files not changed.

💤 eurolite/led-z-200-tcl: qlcplus_4.12.2

Outputted files not changed.

🆚 hazebase/base-hazer-pro: aglight

Changed outputted file aglight_fixture_library.json

--- removed
+++ added
@@ -15,9 +15,9 @@
         "manual": [
           "https://www.steinigke.de/download/51700100-Manual-82145-hazebase-basehazerpro-hazer-en.pdf"
         ],
         "productPage": [
-          "https://www.steinigke.de/index.php?cl=details&mfLang=en&anid=ARTI_51700100"
+          "https://www.steinigke.de/en/mpn51700100-hazebase-basehazerpro-hazer.html"
         ],
         "video": [
           "https://www.youtube.com/watch?v=m1Z7sziCdL0"
         ]

💤 hazebase/base-hazer-pro: color-chief

Outputted files not changed.

💤 hazebase/base-hazer-pro: colorsource

Outputted files not changed.

💤 hazebase/base-hazer-pro: d-light

Outputted files not changed.

💤 hazebase/base-hazer-pro: dmxcontrol3

Outputted files not changed.

🆚 hazebase/base-hazer-pro: dragonframe

Changed outputted file hazebase/base-hazer-pro.json

--- removed
+++ added
@@ -12,9 +12,9 @@
     "manual": [
       "https://www.steinigke.de/download/51700100-Manual-82145-hazebase-basehazerpro-hazer-en.pdf"
     ],
     "productPage": [
-      "https://www.steinigke.de/index.php?cl=details&mfLang=en&anid=ARTI_51700100"
+      "https://www.steinigke.de/en/mpn51700100-hazebase-basehazerpro-hazer.html"
     ],
     "video": [
       "https://www.youtube.com/watch?v=m1Z7sziCdL0"
     ]

💤 hazebase/base-hazer-pro: ecue

Outputted files not changed.

💤 hazebase/base-hazer-pro: millumin

Outputted files not changed.

💤 hazebase/base-hazer-pro: op-z

Outputted files not changed.

💤 hazebase/base-hazer-pro: qlcplus_4.12.2

Outputted files not changed.

🆚 lightmaxx/easy-wash-quad-led: aglight

Changed outputted file aglight_fixture_library.json

--- removed
+++ added
@@ -15,9 +15,9 @@
         "manual": [
           "https://forum.malighting.com/attachment/475-lightmaxx-easy-wash-quad-led-7x10w-rgbw-pdf/"
         ],
         "productPage": [
-          "https://www.musicstore.com/en_RS/EUR/lightmaXX-Easy-Wash-Quad-LED-Moving-Head/art-LIG0009642-000"
+          "https://www.musicstore.com/en_RS/EUR/lightmaXX-Easy-Wash-Quad-Moving-Head-LED/art-LIG0009642-000"
         ],
         "video": [
           "https://www.youtube.com/watch?v=7gJw-aAvHPg"
         ]

💤 lightmaxx/easy-wash-quad-led: color-chief

Outputted files not changed.

💤 lightmaxx/easy-wash-quad-led: colorsource

Outputted files not changed.

💤 lightmaxx/easy-wash-quad-led: d-light

Outputted files not changed.

💤 lightmaxx/easy-wash-quad-led: dmxcontrol3

Outputted files not changed.

🆚 lightmaxx/easy-wash-quad-led: dragonframe

Changed outputted file lightmaxx/easy-wash-quad-led.json

--- removed
+++ added
@@ -12,9 +12,9 @@
     "manual": [
       "https://forum.malighting.com/attachment/475-lightmaxx-easy-wash-quad-led-7x10w-rgbw-pdf/"
     ],
     "productPage": [
-      "https://www.musicstore.com/en_RS/EUR/lightmaXX-Easy-Wash-Quad-LED-Moving-Head/art-LIG0009642-000"
+      "https://www.musicstore.com/en_RS/EUR/lightmaXX-Easy-Wash-Quad-Moving-Head-LED/art-LIG0009642-000"
     ],
     "video": [
       "https://www.youtube.com/watch?v=7gJw-aAvHPg"
     ]

💤 lightmaxx/easy-wash-quad-led: ecue

Outputted files not changed.

💤 lightmaxx/easy-wash-quad-led: millumin

Outputted files not changed.

💤 lightmaxx/easy-wash-quad-led: op-z

Outputted files not changed.

💤 lightmaxx/easy-wash-quad-led: qlcplus_4.12.2

Outputted files not changed.

🆚 magicfx/psyco2jet: aglight

Changed outputted file aglight_fixture_library.json

--- removed
+++ added
@@ -16,9 +16,9 @@
         "manual": [
           "https://www.magicfx.eu/app/uploads/2020/01/MAGICFX_PSYCO2JET_MANUAL.pdf"
         ],
         "productPage": [
-          "https://www.magicfx.eu/product/magicfx-psyco2jet/"
+          "https://web.archive.org/web/20230318035553/https://www.magicfx.eu/product/magicfx-psyco2jet/"
         ],
         "video": [
           "https://www.youtube.com/watch?v=l9QZ8UaUbmg",
           "https://www.youtube.com/watch?v=E4rW5SLIgoo"

💤 magicfx/psyco2jet: color-chief

Outputted files not changed.

💤 magicfx/psyco2jet: colorsource

Outputted files not changed.

💤 magicfx/psyco2jet: d-light

Outputted files not changed.

💤 magicfx/psyco2jet: dmxcontrol3

Outputted files not changed.

🆚 magicfx/psyco2jet: dragonframe

Changed outputted file magicfx/psyco2jet.json

--- removed
+++ added
@@ -13,9 +13,9 @@
     "manual": [
       "https://www.magicfx.eu/app/uploads/2020/01/MAGICFX_PSYCO2JET_MANUAL.pdf"
     ],
     "productPage": [
-      "https://www.magicfx.eu/product/magicfx-psyco2jet/"
+      "https://web.archive.org/web/20230318035553/https://www.magicfx.eu/product/magicfx-psyco2jet/"
     ],
     "video": [
       "https://www.youtube.com/watch?v=l9QZ8UaUbmg",
       "https://www.youtube.com/watch?v=E4rW5SLIgoo"

💤 magicfx/psyco2jet: ecue

Outputted files not changed.

💤 magicfx/psyco2jet: millumin

Outputted files not changed.

💤 magicfx/psyco2jet: op-z

Outputted files not changed.

💤 magicfx/psyco2jet: qlcplus_4.12.2

Outputted files not changed.

🆚 magicfx/smokejet: aglight

Changed outputted file aglight_fixture_library.json

--- removed
+++ added
@@ -16,9 +16,9 @@
         "manual": [
           "https://www.magicfx.eu/app/uploads/2020/01/MAGICFX_SMOKEJET_MANUAL.pdf"
         ],
         "productPage": [
-          "https://www.magicfx.eu/product/magicfx-smokejet/"
+          "https://web.archive.org/web/20230318035556/https://www.magicfx.eu/product/magicfx-smokejet/"
         ],
         "video": [
           "https://www.youtube.com/watch?v=amAVrtUQr4g"
         ]

💤 magicfx/smokejet: color-chief

Outputted files not changed.

💤 magicfx/smokejet: colorsource

Outputted files not changed.

💤 magicfx/smokejet: d-light

Outputted files not changed.

💤 magicfx/smokejet: dmxcontrol3

Outputted files not changed.

🆚 magicfx/smokejet: dragonframe

Changed outputted file magicfx/smokejet.json

--- removed
+++ added
@@ -13,9 +13,9 @@
     "manual": [
       "https://www.magicfx.eu/app/uploads/2020/01/MAGICFX_SMOKEJET_MANUAL.pdf"
     ],
     "productPage": [
-      "https://www.magicfx.eu/product/magicfx-smokejet/"
+      "https://web.archive.org/web/20230318035556/https://www.magicfx.eu/product/magicfx-smokejet/"
     ],
     "video": [
       "https://www.youtube.com/watch?v=amAVrtUQr4g"
     ]

💤 magicfx/smokejet: ecue

Outputted files not changed.

💤 magicfx/smokejet: millumin

Outputted files not changed.

💤 magicfx/smokejet: op-z

Outputted files not changed.

💤 magicfx/smokejet: qlcplus_4.12.2

Outputted files not changed.

🆚 magicfx/stage-flame: aglight

Changed outputted file aglight_fixture_library.json

--- removed
+++ added
@@ -15,9 +15,9 @@
         "manual": [
           "https://www.magicfx.eu/app/uploads/2020/01/MAGICFX_STAGE-FLAME_MANUAL.pdf"
         ],
         "productPage": [
-          "https://www.magicfx.eu/product/magicfx-stage-flame/"
+          "https://web.archive.org/web/20230318035553/https://www.magicfx.eu/product/magicfx-stage-flame/"
         ],
         "video": [
           "https://www.youtube.com/watch?v=YLeYRexsTmc",
           "https://www.youtube.com/watch?v=HvRzNTf07aY"

💤 magicfx/stage-flame: color-chief

Outputted files not changed.

💤 magicfx/stage-flame: colorsource

Outputted files not changed.

💤 magicfx/stage-flame: d-light

Outputted files not changed.

💤 magicfx/stage-flame: dmxcontrol3

Outputted files not changed.

🆚 magicfx/stage-flame: dragonframe

Changed outputted file magicfx/stage-flame.json

--- removed
+++ added
@@ -12,9 +12,9 @@
     "manual": [
       "https://www.magicfx.eu/app/uploads/2020/01/MAGICFX_STAGE-FLAME_MANUAL.pdf"
     ],
     "productPage": [
-      "https://www.magicfx.eu/product/magicfx-stage-flame/"
+      "https://web.archive.org/web/20230318035553/https://www.magicfx.eu/product/magicfx-stage-flame/"
     ],
     "video": [
       "https://www.youtube.com/watch?v=YLeYRexsTmc",
       "https://www.youtube.com/watch?v=HvRzNTf07aY"

💤 magicfx/stage-flame: ecue

Outputted files not changed.

💤 magicfx/stage-flame: millumin

Outputted files not changed.

💤 magicfx/stage-flame: op-z

Outputted files not changed.

💤 magicfx/stage-flame: qlcplus_4.12.2

Outputted files not changed.

🆚 velleman/aeron-250-ii: aglight

Changed outputted file aglight_fixture_library.json

--- removed
+++ added
@@ -12,9 +12,9 @@
       },
       "comment": "VDP250SC8M2",
       "links": {
         "manual": [
-          "https://www.velleman.eu/downloads/4/vdp250sc8m2gbnlfresd.pdf"
+          "https://cdn.velleman.eu/downloads/4/vdp250sc8m2gbnlfresd.pdf"
         ],
         "productPage": [
           "https://www.velleman.eu/products/view/?id=371050"
         ],

💤 velleman/aeron-250-ii: color-chief

Outputted files not changed.

💤 velleman/aeron-250-ii: colorsource

Outputted files not changed.

💤 velleman/aeron-250-ii: d-light

Outputted files not changed.

💤 velleman/aeron-250-ii: dmxcontrol3

Outputted files not changed.

🆚 velleman/aeron-250-ii: dragonframe

Changed outputted file velleman/aeron-250-ii.json

--- removed
+++ added
@@ -9,9 +9,9 @@
   },
   "comment": "VDP250SC8M2",
   "links": {
     "manual": [
-      "https://www.velleman.eu/downloads/4/vdp250sc8m2gbnlfresd.pdf"
+      "https://cdn.velleman.eu/downloads/4/vdp250sc8m2gbnlfresd.pdf"
     ],
     "productPage": [
       "https://www.velleman.eu/products/view/?id=371050"
     ],

💤 velleman/aeron-250-ii: ecue

Outputted files not changed.

🆚 velleman/aeron-250-ii: millumin

Changed outputted file velleman/aeron-250-ii.json

--- removed
+++ added
@@ -7,9 +7,9 @@
     "createDate": "2021-09-14",
     "lastModifyDate": "2021-09-14"
   },
   "comment": "VDP250SC8M2",
-  "manualURL": "https://www.velleman.eu/downloads/4/vdp250sc8m2gbnlfresd.pdf",
+  "manualURL": "https://cdn.velleman.eu/downloads/4/vdp250sc8m2gbnlfresd.pdf",
   "physical": {
     "dimensions": [535, 295, 180],
     "weight": 13.95,
     "power": 350,

💤 velleman/aeron-250-ii: op-z

Outputted files not changed.

💤 velleman/aeron-250-ii: qlcplus_4.12.2

Outputted files not changed.

github-actions · 2023-10-22T17:32:22Z

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ eurolite / led-z-200-tcl: d-light / attributes-correctness

✔️ eurolite/led-z-200-tcl-6ch.xml

✔️ eurolite / led-z-200-tcl: dmxcontrol3 / channel-numbers

✔️ eurolite-led-z-200-tcl-6ch.xml

✔️ eurolite / led-z-200-tcl: dragonframe / json-schema-conformity

✔️ eurolite/led-z-200-tcl.json
✔️ manufacturers.json

✔️ eurolite / led-z-200-tcl: millumin / json-schema-conformity

✔️ eurolite/led-z-200-tcl.json

✔️ eurolite / led-z-200-tcl: qlcplus_4.12.2 / fixture-tool-validation

✔️ fixtures/Eurolite-LED-Z-200-TCL.qxf

✔️ eurolite / led-z-200-tcl: qlcplus_4.12.2 / xsd-schema-conformity

✔️ fixtures/Eurolite-LED-Z-200-TCL.qxf

✔️ hazebase / base-hazer-pro: d-light / attributes-correctness

✔️ hazebase/base-hazer-pro-2ch.xml

✔️ hazebase / base-hazer-pro: dmxcontrol3 / channel-numbers

✔️ hazebase-base-hazer-pro-2ch.xml

✔️ hazebase / base-hazer-pro: dragonframe / json-schema-conformity

✔️ hazebase/base-hazer-pro.json
✔️ manufacturers.json

✔️ hazebase / base-hazer-pro: millumin / json-schema-conformity

✔️ hazebase/base-hazer-pro.json

✔️ hazebase / base-hazer-pro: qlcplus_4.12.2 / fixture-tool-validation

✔️ fixtures/Hazebase-basehazerpro.qxf

✔️ hazebase / base-hazer-pro: qlcplus_4.12.2 / xsd-schema-conformity

✔️ fixtures/Hazebase-basehazerpro.qxf

✔️ lightmaxx / easy-wash-quad-led: d-light / attributes-correctness

✔️ lightmaxx/easy-wash-quad-led-8ch.xml
✔️ lightmaxx/easy-wash-quad-led-13ch.xml

✔️ lightmaxx / easy-wash-quad-led: dmxcontrol3 / channel-numbers

✔️ lightmaxx-easy-wash-quad-led-8ch.xml
✔️ lightmaxx-easy-wash-quad-led-13ch.xml

✔️ lightmaxx / easy-wash-quad-led: dragonframe / json-schema-conformity

✔️ lightmaxx/easy-wash-quad-led.json
✔️ manufacturers.json

✔️ lightmaxx / easy-wash-quad-led: millumin / json-schema-conformity

✔️ lightmaxx/easy-wash-quad-led.json

✔️ lightmaxx / easy-wash-quad-led: qlcplus_4.12.2 / fixture-tool-validation

✔️ fixtures/lightmaXX-Easy-Wash-Quad-LED.qxf

✔️ lightmaxx / easy-wash-quad-led: qlcplus_4.12.2 / xsd-schema-conformity

✔️ fixtures/lightmaXX-Easy-Wash-Quad-LED.qxf

✔️ magicfx / psyco2jet: d-light / attributes-correctness

✔️ magicfx/psyco2jet-Safety.xml
✔️ magicfx/psyco2jet-Raw.xml
✔️ magicfx/psyco2jet-Preset.xml

✔️ magicfx / psyco2jet: dmxcontrol3 / channel-numbers

✔️ magicfx-psyco2jet-Safety.xml
✔️ magicfx-psyco2jet-Raw.xml
✔️ magicfx-psyco2jet-Preset.xml

✔️ magicfx / psyco2jet: dragonframe / json-schema-conformity

✔️ magicfx/psyco2jet.json
✔️ manufacturers.json

✔️ magicfx / psyco2jet: millumin / json-schema-conformity

✔️ magicfx/psyco2jet.json

✔️ magicfx / psyco2jet: qlcplus_4.12.2 / fixture-tool-validation

✔️ fixtures/MagicFX-PSYCO2JET.qxf

✔️ magicfx / psyco2jet: qlcplus_4.12.2 / xsd-schema-conformity

✔️ fixtures/MagicFX-PSYCO2JET.qxf

✔️ magicfx / smokejet: d-light / attributes-correctness

✔️ magicfx/smokejet-9ch.xml

✔️ magicfx / smokejet: dmxcontrol3 / channel-numbers

✔️ magicfx-smokejet-9ch.xml

✔️ magicfx / smokejet: dragonframe / json-schema-conformity

✔️ magicfx/smokejet.json
✔️ manufacturers.json

✔️ magicfx / smokejet: millumin / json-schema-conformity

✔️ magicfx/smokejet.json

✔️ magicfx / smokejet: qlcplus_4.12.2 / fixture-tool-validation

✔️ fixtures/MagicFX-SMOKEJET.qxf

✔️ magicfx / smokejet: qlcplus_4.12.2 / xsd-schema-conformity

✔️ fixtures/MagicFX-SMOKEJET.qxf

✔️ magicfx / stage-flame: d-light / attributes-correctness

✔️ magicfx/stage-flame-Default.xml

✔️ magicfx / stage-flame: dmxcontrol3 / channel-numbers

✔️ magicfx-stage-flame-Default.xml

✔️ magicfx / stage-flame: dragonframe / json-schema-conformity

✔️ magicfx/stage-flame.json
✔️ manufacturers.json

✔️ magicfx / stage-flame: millumin / json-schema-conformity

✔️ magicfx/stage-flame.json

✔️ magicfx / stage-flame: qlcplus_4.12.2 / fixture-tool-validation

✔️ fixtures/MagicFX-Stage-Flame.qxf

✔️ magicfx / stage-flame: qlcplus_4.12.2 / xsd-schema-conformity

✔️ fixtures/MagicFX-Stage-Flame.qxf

✔️ velleman / aeron-250-ii: d-light / attributes-correctness

✔️ velleman/aeron-250-ii-8ch.xml

✔️ velleman / aeron-250-ii: dmxcontrol3 / channel-numbers

✔️ velleman-aeron-250-ii-8ch.xml

✔️ velleman / aeron-250-ii: dragonframe / json-schema-conformity

✔️ velleman/aeron-250-ii.json
✔️ manufacturers.json

✔️ velleman / aeron-250-ii: millumin / json-schema-conformity

✔️ velleman/aeron-250-ii.json

❌ velleman / aeron-250-ii: qlcplus_4.12.2 / fixture-tool-validation

❌ fixtures/Velleman-Aeron-250-II.qxf
Namespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid PAN degrees ./manufacturer/fixture.qxf: Invalid TILT degrees 1 definitions processed. 2 errors detected

✔️ velleman / aeron-250-ii: qlcplus_4.12.2 / xsd-schema-conformity

✔️ fixtures/Velleman-Aeron-250-II.qxf

FloEdelmann

Looks good, thanks 😊
We might want to exclude links to the Internet Archive from the external link checker (in another PR), because they are designed to be available "forever" and we don't want to put unnecessary load on their servers.

luc122c · 2023-10-22T20:19:25Z

Good idea, I can have a crack at that.

luc122c added 2 commits October 22, 2023 18:23

Update links to follow redirects

7dc8784

Replace links with web archive - pages removed

f93ef44

luc122c added the component-fixture Affects one or more existing fixture definitions. label Oct 22, 2023

luc122c requested a review from FloEdelmann October 22, 2023 17:29

FloEdelmann approved these changes Oct 22, 2023

View reviewed changes

FloEdelmann merged commit 8181c13 into master Oct 22, 2023

FloEdelmann deleted the fix-links-2 branch October 22, 2023 20:03

luc122c mentioned this pull request Oct 22, 2023

Exclude wayback machine URLs in link checker #3555

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix links #3551

Fix links #3551

Uh oh!

luc122c commented Oct 22, 2023

Uh oh!

github-actions bot commented Oct 22, 2023

Uh oh!

github-actions bot commented Oct 22, 2023

Uh oh!

FloEdelmann left a comment

Uh oh!

luc122c commented Oct 22, 2023

Uh oh!

Uh oh!

Fix links #3551

Fix links #3551

Uh oh!

Conversation

luc122c commented Oct 22, 2023

Uh oh!

github-actions bot commented Oct 22, 2023

Plugin export diff

Uh oh!

github-actions bot commented Oct 22, 2023

Export files validity

Uh oh!

FloEdelmann left a comment

Choose a reason for hiding this comment

Uh oh!

luc122c commented Oct 22, 2023

Uh oh!

Uh oh!