-
Notifications
You must be signed in to change notification settings - Fork 72
External Link Checker: Open in new tab #3517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External Link Checker: Open in new tab #3517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be nicer for the links to open in a new tab
I don't have a strong opinion on this, but I'm fine with the change.
if it's worth truncating the length of the URL to prevent the table from extending past the width of the comment
Yes, I think that would be a good improvement, since the icons column should always be visible. Or maybe we just have to swap the columns around?
I like that idea better, since no data is lost. I'll do that now. |
@FloEdelmann I really struggled to get the Markdown formatting right with the |
Thanks, it looks much neater now. Good spot with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks 🙂
I'll update the description of #999 manually to the new format now, so that the parser doesn't fail.
When checking the links from #999, I thought it might be nicer for the links to open in a new tab (since they are external to GitHub).
I was also wondering if it's worth truncating the length of the URL to prevent the table from extending past the width of the comment?