Skip to content

Update links #3112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Update links #3112

merged 4 commits into from
Feb 28, 2023

Conversation

luc122c
Copy link
Contributor

@luc122c luc122c commented Feb 28, 2023

@luc122c luc122c added the component-fixture Affects one or more existing fixture definitions. label Feb 28, 2023
@luc122c luc122c requested a review from FloEdelmann February 28, 2023 21:57
@luc122c luc122c self-assigned this Feb 28, 2023
@github-actions
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ chauvet-professional / colorado-1-solo: d-light / attributes-correctness
  • ✔️ chauvet-professional/colorado-1-solo-Std. Y.xml
  • ✔️ chauvet-professional/colorado-1-solo-TR16.xml
  • ✔️ chauvet-professional/colorado-1-solo-TOUR.xml
  • ✔️ chauvet-professional/colorado-1-solo-SSP.xml
  • ✔️ chauvet-professional/colorado-1-solo-HSIC.xml
chauvet-professional / colorado-1-solo: dmxcontrol3 / channel-numbers
  • ❌ chauvet-professional-colorado-1-solo-Std.-Y.xmlCapability 10…99 in channel 12 overlaps with other capabilities.
    Channel 11 "Color Macros" is missing capabilities. Used ranges: 0…11, 30…31, 50…51, 70…71, 90…91, 110…111, 130…131, 150…151, 170…255
    Channel 12 "Strobe" is missing capabilities. Used ranges: 10…99, 110…179, 190…255
  • ❌ chauvet-professional-colorado-1-solo-TR16.xmlCapability 10…99 in channel 12 overlaps with other capabilities.
    Channel 11 "Color Macros" is missing capabilities. Used ranges: 0…11, 30…31, 50…51, 70…71, 90…91, 110…111, 130…131, 150…151, 170…255
    Channel 12 "Strobe" is missing capabilities. Used ranges: 10…99, 110…179, 190…255
  • ❌ chauvet-professional-colorado-1-solo-TOUR.xmlCapability 10…99 in channel 7 overlaps with other capabilities.
    Channel 6 "Color Macros" is missing capabilities. Used ranges: 0…11, 30…31, 50…51, 70…71, 90…91, 110…111, 130…131, 150…151, 170…255
    Channel 7 "Strobe" is missing capabilities. Used ranges: 10…99, 110…179, 190…255
  • ❌ chauvet-professional-colorado-1-solo-SSP.xmlCapability 10…99 in channel 6 overlaps with other capabilities.
    Channel 6 "Strobe" is missing capabilities. Used ranges: 10…99, 110…179, 190…255
  • ❌ chauvet-professional-colorado-1-solo-HSIC.xmlCapability 10…99 in channel 6 overlaps with other capabilities.
    Channel 6 "Strobe" is missing capabilities. Used ranges: 10…99, 110…179, 190…255
✔️ chauvet-professional / colorado-1-solo: dragonframe / json-schema-conformity
  • ✔️ chauvet-professional/colorado-1-solo.json
  • ✔️ manufacturers.json
chauvet-professional / colorado-1-solo: millumin / json-schema-conformity
  • ❌ chauvet-professional/colorado-1-solo.jsonfixture/physical/DMXconnector "5-pin XLR IP65" must be equal to one of [3-pin, 5-pin, 3-pin (swapped +/-), 3-pin and 5-pin, 3-pin XLR IP65, 3.5mm stereo jack]
✔️ chauvet-professional / colorado-1-solo: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Chauvet-Professional-COLORado-1-Solo.qxf
chauvet-professional / colorado-1-solo: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/Chauvet-Professional-COLORado-1-Solo.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Technical', attribute 'DmxConnector': [facet 'enumeration'] The value '5-pin XLR IP65' is not an element of the set {'3-pin', '5-pin', '3-pin and 5-pin', '3-pin IP65', '5-pin IP65', '3.5 mm stereo jack', 'Wireless', 'Other'}.
    Element '{http://www.qlcplus.org/FixtureDefinition}Technical', attribute 'DmxConnector': '5-pin XLR IP65' is not a valid value of the atomic type '{http://www.qlcplus.org/FixtureDefinition}connectorType'.

This reverts commit 080bef3.
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this!

@FloEdelmann FloEdelmann enabled auto-merge (squash) February 28, 2023 22:13
@github-actions
Copy link

Plugin export diff

(Output of test script tests/github/export-diff.js.)

You can view your uncommitted changes in plugin exports manually by executing:
$ node cli/diff-plugin-outputs.js -p <plugin-key> [-c <compare-plugin-key>] <fixtures>

🆚 chauvet-professional/colorado-1-solo: aglight
Changed outputted file aglight_fixture_library.json
--- removed
+++ added
@@ -12,12 +12,12 @@
         "lastModifyDate": "2022-04-19"
       },
       "links": {
         "productPage": [
-          "https://www.chauvetprofessional.eu/products/colorado-1-solo/"
+          "https://www.chauvetprofessional.com/products/colorado-1-solo/"
         ],
         "manual": [
-          "https://www.chauvetprofessional.eu/wp-content/uploads//2018/01/COLORado_1_Solo_UM_Rev8.pdf"
+          "https://www.chauvetprofessional.com/wp-content/uploads//2018/01/COLORado_1_Solo_UM_Rev8.pdf"
         ],
         "video": [
           "https://www.youtube.com/watch?v=0hqRufKRupk"
         ]
💤 chauvet-professional/colorado-1-solo: color-chief Outputted files not changed.
💤 chauvet-professional/colorado-1-solo: colorsource Outputted files not changed.
💤 chauvet-professional/colorado-1-solo: d-light Outputted files not changed.
💤 chauvet-professional/colorado-1-solo: dmxcontrol3 Outputted files not changed.
🆚 chauvet-professional/colorado-1-solo: dragonframe
Changed outputted file chauvet-professional/colorado-1-solo.json
--- removed
+++ added
@@ -9,12 +9,12 @@
     "lastModifyDate": "2022-04-19"
   },
   "links": {
     "productPage": [
-      "https://www.chauvetprofessional.eu/products/colorado-1-solo/"
+      "https://www.chauvetprofessional.com/products/colorado-1-solo/"
     ],
     "manual": [
-      "https://www.chauvetprofessional.eu/wp-content/uploads//2018/01/COLORado_1_Solo_UM_Rev8.pdf"
+      "https://www.chauvetprofessional.com/wp-content/uploads//2018/01/COLORado_1_Solo_UM_Rev8.pdf"
     ],
     "video": [
       "https://www.youtube.com/watch?v=0hqRufKRupk"
     ]
💤 chauvet-professional/colorado-1-solo: ecue Outputted files not changed.
🆚 chauvet-professional/colorado-1-solo: millumin
Changed outputted file chauvet-professional/colorado-1-solo.json
--- removed
+++ added
@@ -7,9 +7,9 @@
     "authors": ["Da Graca Neves Eric", "Ken Harris"],
     "createDate": "2022-04-19",
     "lastModifyDate": "2022-04-19"
   },
-  "manualURL": "https://www.chauvetprofessional.eu/wp-content/uploads//2018/01/COLORado_1_Solo_UM_Rev8.pdf",
+  "manualURL": "https://www.chauvetprofessional.com/wp-content/uploads//2018/01/COLORado_1_Solo_UM_Rev8.pdf",
   "physical": {
     "dimensions": [242, 176, 346],
     "weight": 5.4,
     "power": 65,
💤 chauvet-professional/colorado-1-solo: op-z Outputted files not changed.
💤 chauvet-professional/colorado-1-solo: qlcplus_4.12.2 Outputted files not changed.

@FloEdelmann FloEdelmann merged commit 63d931d into master Feb 28, 2023
@FloEdelmann FloEdelmann deleted the update-links-luke branch February 28, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-fixture Affects one or more existing fixture definitions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants