Skip to content

Fix short links #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Fix short links #2855

merged 3 commits into from
Oct 14, 2022

Conversation

luc122c
Copy link
Contributor

@luc122c luc122c commented Oct 14, 2022

It seems like the bot doesn't like YouTube's short URLs. This PR replaces the URLs.
Found by #999.

@luc122c luc122c added bug Something doesn't work as intended. component-fixture Affects one or more existing fixture definitions. labels Oct 14, 2022
@luc122c luc122c requested a review from FloEdelmann October 14, 2022 22:04
@github-actions
Copy link

Plugin export diff

(Output of test script tests/github/export-diff.js.)

You can view your uncommitted changes in plugin exports manually by executing:
$ node cli/diff-plugin-outputs.js -p <plugin-key> [-c <compare-plugin-key>] <fixtures>

🆚 eurolite/led-bar-6-qcl-rgbw: aglight
Changed outputted file aglight_fixture_library.json
--- removed
+++ added
@@ -22,9 +22,9 @@
         "productPage": [
           "https://www.thomann.de/gb/eurolite_led_bar_6_qcl_rgbw.htm"
         ],
         "video": [
-          "https://youtu.be/tXEgjiP5YWA"
+          "https://www.youtube.com/watch?v=tXEgjiP5YWA"
         ]
       },
       "physical": {
         "dimensions": [585, 65, 100],
💤 eurolite/led-bar-6-qcl-rgbw: color-chief Outputted files not changed.
💤 eurolite/led-bar-6-qcl-rgbw: colorsource Outputted files not changed.
💤 eurolite/led-bar-6-qcl-rgbw: d-light Outputted files not changed.
💤 eurolite/led-bar-6-qcl-rgbw: dmxcontrol3 Outputted files not changed.
🆚 eurolite/led-bar-6-qcl-rgbw: dragonframe
Changed outputted file eurolite/led-bar-6-qcl-rgbw.json
--- removed
+++ added
@@ -19,9 +19,9 @@
     "productPage": [
       "https://www.thomann.de/gb/eurolite_led_bar_6_qcl_rgbw.htm"
     ],
     "video": [
-      "https://youtu.be/tXEgjiP5YWA"
+      "https://www.youtube.com/watch?v=tXEgjiP5YWA"
     ]
   },
   "physical": {
     "dimensions": [585, 65, 100],
💤 eurolite/led-bar-6-qcl-rgbw: ecue Outputted files not changed.
💤 eurolite/led-bar-6-qcl-rgbw: millumin Outputted files not changed.
💤 eurolite/led-bar-6-qcl-rgbw: op-z Outputted files not changed.
💤 eurolite/led-bar-6-qcl-rgbw: qlcplus_4.12.2 Outputted files not changed.
🆚 flash-professional/led-par-64-cob-300w-rgbwauv: aglight
Changed outputted file aglight_fixture_library.json
--- removed
+++ added
@@ -17,9 +17,9 @@
         "productPage": [
           "https://flash-butrym.pl/en_US/p/LED-PAR-64-300W-6in1-COB-RGBWA-UV-BARNDOOR/406"
         ],
         "video": [
-          "https://www.youtube.com/watch?v=TJtqvw6y7ss&feature=youtu.be"
+          "https://www.youtube.com/watch?v=TJtqvw6y7ss"
         ]
       },
       "physical": {
         "dimensions": [270, 280, 240],
💤 flash-professional/led-par-64-cob-300w-rgbwauv: color-chief Outputted files not changed.
💤 flash-professional/led-par-64-cob-300w-rgbwauv: colorsource Outputted files not changed.
💤 flash-professional/led-par-64-cob-300w-rgbwauv: d-light Outputted files not changed.
💤 flash-professional/led-par-64-cob-300w-rgbwauv: dmxcontrol3 Outputted files not changed.
🆚 flash-professional/led-par-64-cob-300w-rgbwauv: dragonframe
Changed outputted file flash-professional/led-par-64-cob-300w-rgbwauv.json
--- removed
+++ added
@@ -14,9 +14,9 @@
     "productPage": [
       "https://flash-butrym.pl/en_US/p/LED-PAR-64-300W-6in1-COB-RGBWA-UV-BARNDOOR/406"
     ],
     "video": [
-      "https://www.youtube.com/watch?v=TJtqvw6y7ss&feature=youtu.be"
+      "https://www.youtube.com/watch?v=TJtqvw6y7ss"
     ]
   },
   "physical": {
     "dimensions": [270, 280, 240],
💤 flash-professional/led-par-64-cob-300w-rgbwauv: ecue Outputted files not changed.
💤 flash-professional/led-par-64-cob-300w-rgbwauv: millumin Outputted files not changed.
💤 flash-professional/led-par-64-cob-300w-rgbwauv: op-z Outputted files not changed.
💤 flash-professional/led-par-64-cob-300w-rgbwauv: qlcplus_4.12.2 Outputted files not changed.
🆚 varytec/giga-bar-frost-pix-8-rgb: aglight
Changed outputted file aglight_fixture_library.json
--- removed
+++ added
@@ -22,9 +22,9 @@
         "productPage": [
           "https://www.thomann.de/gb/varytec_giga_bar_frost_pix_8_rgb.htm"
         ],
         "video": [
-          "https://youtu.be/PixpS09Mc-I"
+          "https://www.youtube.com/watch?v=PixpS09Mc-I"
         ]
       },
       "physical": {
         "dimensions": [1020, 80, 65],
💤 varytec/giga-bar-frost-pix-8-rgb: color-chief Outputted files not changed.
💤 varytec/giga-bar-frost-pix-8-rgb: colorsource Outputted files not changed.
💤 varytec/giga-bar-frost-pix-8-rgb: d-light Outputted files not changed.
💤 varytec/giga-bar-frost-pix-8-rgb: dmxcontrol3 Outputted files not changed.
🆚 varytec/giga-bar-frost-pix-8-rgb: dragonframe
Changed outputted file varytec/giga-bar-frost-pix-8-rgb.json
--- removed
+++ added
@@ -19,9 +19,9 @@
     "productPage": [
       "https://www.thomann.de/gb/varytec_giga_bar_frost_pix_8_rgb.htm"
     ],
     "video": [
-      "https://youtu.be/PixpS09Mc-I"
+      "https://www.youtube.com/watch?v=PixpS09Mc-I"
     ]
   },
   "physical": {
     "dimensions": [1020, 80, 65],
💤 varytec/giga-bar-frost-pix-8-rgb: ecue Outputted files not changed.
💤 varytec/giga-bar-frost-pix-8-rgb: millumin Outputted files not changed.
💤 varytec/giga-bar-frost-pix-8-rgb: op-z Outputted files not changed.
💤 varytec/giga-bar-frost-pix-8-rgb: qlcplus_4.12.2 Outputted files not changed.

@github-actions
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ eurolite / led-bar-6-qcl-rgbw: d-light / attributes-correctness
  • ✔️ eurolite/led-bar-6-qcl-rgbw-2ch.xml
  • ✔️ eurolite/led-bar-6-qcl-rgbw-4ch.xml
  • ✔️ eurolite/led-bar-6-qcl-rgbw-5ch.xml
  • ✔️ eurolite/led-bar-6-qcl-rgbw-6ch.xml
  • ✔️ eurolite/led-bar-6-qcl-rgbw-9ch.xml
✔️ eurolite / led-bar-6-qcl-rgbw: dmxcontrol3 / channel-numbers
  • ✔️ eurolite-led-bar-6-qcl-rgbw-2ch.xml
  • ✔️ eurolite-led-bar-6-qcl-rgbw-4ch.xml
  • ✔️ eurolite-led-bar-6-qcl-rgbw-5ch.xml
  • ✔️ eurolite-led-bar-6-qcl-rgbw-6ch.xml
  • ✔️ eurolite-led-bar-6-qcl-rgbw-9ch.xml
✔️ eurolite / led-bar-6-qcl-rgbw: dragonframe / json-schema-conformity
  • ✔️ eurolite/led-bar-6-qcl-rgbw.json
  • ✔️ manufacturers.json
✔️ eurolite / led-bar-6-qcl-rgbw: millumin / json-schema-conformity
  • ✔️ eurolite/led-bar-6-qcl-rgbw.json
✔️ eurolite / led-bar-6-qcl-rgbw: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Eurolite-LED-Bar-6-QCL-RGBW.qxf
✔️ eurolite / led-bar-6-qcl-rgbw: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Eurolite-LED-Bar-6-QCL-RGBW.qxf
✔️ flash-professional / led-par-64-cob-300w-rgbwauv: d-light / attributes-correctness
  • ✔️ flash-professional/led-par-64-cob-300w-rgbwauv-8ch.xml
  • ✔️ flash-professional/led-par-64-cob-300w-rgbwauv-10ch1.xml
  • ✔️ flash-professional/led-par-64-cob-300w-rgbwauv-10ch2.xml
✔️ flash-professional / led-par-64-cob-300w-rgbwauv: dmxcontrol3 / channel-numbers
  • ✔️ flash-professional-led-par-64-cob-300w-rgbwauv-8ch.xml
  • ✔️ flash-professional-led-par-64-cob-300w-rgbwauv-10ch1.xml
  • ✔️ flash-professional-led-par-64-cob-300w-rgbwauv-10ch2.xml
✔️ flash-professional / led-par-64-cob-300w-rgbwauv: dragonframe / json-schema-conformity
  • ✔️ flash-professional/led-par-64-cob-300w-rgbwauv.json
  • ✔️ manufacturers.json
✔️ flash-professional / led-par-64-cob-300w-rgbwauv: millumin / json-schema-conformity
  • ✔️ flash-professional/led-par-64-cob-300w-rgbwauv.json
✔️ flash-professional / led-par-64-cob-300w-rgbwauv: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Flash-Professional-LED-PAR-64-COB-300W-RGBWAUV.qxf
✔️ flash-professional / led-par-64-cob-300w-rgbwauv: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Flash-Professional-LED-PAR-64-COB-300W-RGBWAUV.qxf
✔️ varytec / giga-bar-frost-pix-8-rgb: d-light / attributes-correctness
  • ✔️ varytec/giga-bar-frost-pix-8-rgb-3ch.xml
  • ✔️ varytec/giga-bar-frost-pix-8-rgb-5ch.xml
  • ✔️ varytec/giga-bar-frost-pix-8-rgb-2ch.xml
  • ✔️ varytec/giga-bar-frost-pix-8-rgb-24ch.xml
✔️ varytec / giga-bar-frost-pix-8-rgb: dmxcontrol3 / channel-numbers
  • ✔️ varytec-giga-bar-frost-pix-8-rgb-3ch.xml
  • ✔️ varytec-giga-bar-frost-pix-8-rgb-5ch.xml
  • ✔️ varytec-giga-bar-frost-pix-8-rgb-2ch.xml
  • ✔️ varytec-giga-bar-frost-pix-8-rgb-24ch.xml
✔️ varytec / giga-bar-frost-pix-8-rgb: dragonframe / json-schema-conformity
  • ✔️ varytec/giga-bar-frost-pix-8-rgb.json
  • ✔️ manufacturers.json
varytec / giga-bar-frost-pix-8-rgb: millumin / json-schema-conformity
  • ❌ varytec/giga-bar-frost-pix-8-rgb.jsonfixture/availableChannels/No function (type: Nothing) must NOT have more than 1 properties
    fixture/availableChannels/No function (type: Nothing) must have required property 'name'
    fixture/availableChannels/No function (type: Nothing) must match exactly one schema in oneOf
✔️ varytec / giga-bar-frost-pix-8-rgb: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Varytec-Giga-Bar-Frost-Pix-8-RGB.qxf
✔️ varytec / giga-bar-frost-pix-8-rgb: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Varytec-Giga-Bar-Frost-Pix-8-RGB.qxf

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@FloEdelmann FloEdelmann enabled auto-merge (squash) October 14, 2022 22:11
@FloEdelmann FloEdelmann disabled auto-merge October 14, 2022 22:11
@FloEdelmann FloEdelmann enabled auto-merge (squash) October 14, 2022 22:11
@FloEdelmann FloEdelmann merged commit 99d003f into master Oct 14, 2022
@FloEdelmann FloEdelmann deleted the fix-short-links branch October 14, 2022 22:12
@luc122c luc122c restored the fix-short-links branch February 28, 2023 22:18
@luc122c luc122c deleted the fix-short-links branch February 28, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't work as intended. component-fixture Affects one or more existing fixture definitions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants