Skip to content

Fix some broken links #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 18, 2020
Merged

Fix some broken links #1453

merged 5 commits into from
Sep 18, 2020

Conversation

FloEdelmann
Copy link
Member

References #999.

@FloEdelmann FloEdelmann added bug Something doesn't work as intended. component-fixture Affects one or more existing fixture definitions. labels Sep 14, 2020
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-1453 September 14, 2020 16:52 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-1453 September 14, 2020 20:10 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-1453 September 18, 2020 16:08 Inactive
@FloEdelmann FloEdelmann mentioned this pull request Sep 18, 2020
Merged
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-1453 September 18, 2020 17:04 Inactive
@FloEdelmann
Copy link
Member Author

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ afx / lmh460z: d-light / attributes-correctness
  • ✔️ afx/lmh460z-Default.xml
✔️ afx / lmh460z: millumin / json-schema-conformity
  • ✔️ afx/lmh460z.json
✔️ afx / lmh460z: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/AFX-LMH460Z.qxf
✔️ afx / lmh460z: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/AFX-LMH460Z.qxf
✔️ gantom / precision-dmx: d-light / attributes-correctness
  • ✔️ gantom/precision-dmx-3ch.xml
  • ✔️ gantom/precision-dmx-7ch.xml
✔️ gantom / precision-dmx: millumin / json-schema-conformity
  • ✔️ gantom/precision-dmx.json
✔️ gantom / precision-dmx: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Gantom-Precision-DMX.qxf
❌ gantom / precision-dmx: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/Gantom-Precision-DMX.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': '0' is not a valid value of the atomic type '{http://www.qlcplus.org/FixtureDefinition}weightType'.
✔️ ibiza-light / lp64-led-promo: d-light / attributes-correctness
  • ✔️ ibiza-light/lp64-led-promo-7ch.xml
✔️ ibiza-light / lp64-led-promo: millumin / json-schema-conformity
  • ✔️ ibiza-light/lp64-led-promo.json
✔️ ibiza-light / lp64-led-promo: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Ibiza-light-LP64-LED-PROMO.qxf
✔️ ibiza-light / lp64-led-promo: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Ibiza-light-LP64-LED-PROMO.qxf
✔️ mega-led-lighting / zoom-360: d-light / attributes-correctness
  • ✔️ mega-led-lighting/zoom-360-16ch.xml
  • ✔️ mega-led-lighting/zoom-360-12ch.xml
✔️ mega-led-lighting / zoom-360: millumin / json-schema-conformity
  • ✔️ mega-led-lighting/zoom-360.json
✔️ mega-led-lighting / zoom-360: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Mega-LED-Lighting-ZOOM-360.qxf
✔️ mega-led-lighting / zoom-360: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Mega-LED-Lighting-ZOOM-360.qxf

@FloEdelmann
Copy link
Member Author

Plugin export diff

(Output of test script tests/github/export-diff.js.)

You can view your uncommitted changes in plugin exports manually by executing:
$ node cli/diff-plugin-outputs.js -p <plugin-key> [-c <compare-plugin-key>] <fixtures>

🆚 afx/lmh460z: aglight
Changed outputted file aglight_fixture_library.json 
--- removed
+++ added
@@ -13,18 +13,17 @@
       },
       "comment": "Wash Zoom LED",
       "links": {
         "productPage": [
-          "http://ns351448.ovh.net/~bstdj/187.html"
+          "https://www.afx-light.com/afx-led-moving-head-wash-36x10w-4-in-1-rgbw-led-zoom.html"
         ],
         "video": [
           "https://www.youtube.com/watch?v=Y6BBSuRVWwQ",
           "https://www.youtube.com/watch?v=vEnjSQS7QY0",
           "https://www.youtube.com/watch?v=-POl9ZfaeQs"
         ],
         "other": [
-          "http://ns351448.ovh.net/~bstdj/wa_files/FICHE_20LMH460Z.pdf",
-          "http://ns351448.ovh.net/~bstdj/wa_files/Page_20LMH460Z.pdf"
+          "https://www.afx-light.com/media/catalog/product/fiches/LMH460Z-2_F_fr.pdf"
         ]
       },
       "helpWanted": "Please provide a manual.",
       "physical": {
💤 afx/lmh460z: colorsource Outputted files not changed.
💤 afx/lmh460z: d-light Outputted files not changed.
💤 afx/lmh460z: ecue Outputted files not changed.
💤 afx/lmh460z: millumin Outputted files not changed.
💤 afx/lmh460z: op-z Outputted files not changed.
💤 afx/lmh460z: qlcplus_4.12.2 Outputted files not changed.
🆚 gantom/precision-dmx: aglight
Changed outputted file aglight_fixture_library.json 
--- removed
+++ added
@@ -11,10 +11,10 @@
         "lastModifyDate": "2020-03-28"
       },
       "links": {
         "manual": [
-          "http://www.gantom.com/wp-content/uploads/2018/07/Precision-DMX-User-Guide-1.1.pdf",
-          "http://www.gantom.com/wp-content/uploads/2018/05/Precision_DMX_2018.pdf"
+          "https://www.gantom.com/wp-content/uploads/2018/07/Precision-DMX-User-Guide-1.1.pdf",
+          "https://www.gantom.com/wp-content/uploads/2018/05/Precision_DMX_2018.pdf"
         ],
         "productPage": [
           "https://www.gantom.com/lighting-fixtures/precision-dmx/"
         ],
@@ -210,9 +210,9 @@
       ],
       "fixtureKey": "precision-dmx",
       "manufacturer": {
         "name": "Gantom",
-        "website": "http://www.gantom.com"
+        "website": "https://www.gantom.com"
       },
       "oflURL": "https://open-fixture-library.org/gantom/precision-dmx"
     }
   ]
💤 gantom/precision-dmx: colorsource Outputted files not changed.
💤 gantom/precision-dmx: d-light Outputted files not changed.
🆚 gantom/precision-dmx: ecue
Changed outputted file UserLibrary.xml 
--- removed
+++ added
@@ -1,9 +1,9 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <Document Owner="user" TypeVersion="2" SaveTimeStamp="2020-09-18#17:06:36">
     <Library>
         <Fixtures>
-            <Manufacturer _CreationDate="2020-09-18#17:06:36" _ModifiedDate="2020-09-18#17:06:36" Name="Gantom" Comment="" Web="http://www.gantom.com">
+            <Manufacturer _CreationDate="2020-09-18#17:06:36" _ModifiedDate="2020-09-18#17:06:36" Name="Gantom" Comment="" Web="https://www.gantom.com">
                 <Fixture _CreationDate="2020-03-28#00:00:00" _ModifiedDate="2020-03-28#00:00:00" Name="Precision DMX (3ch mode)" NameShort="Precision DMX-3ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.org/gantom/precision-dmx" AllocateDmxChannels="3" Weight="0" Power="3.8" DimWidth="44.5" DimHeight="52.5" DimDepth="52">
                     <ChannelColor Name="Red" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="1" DmxByte1="0" Constant="0" Crossfade="1" Invert="0" Precedence="LTP" ClassicPos="1">
                         <Range Name="Red off…bright" Start="0" End="255" AutoMenu="1" Centre="0"/>
                     </ChannelColor>
@@ -48,8 +48,8 @@
                 </Fixture>
             </Manufacturer>
         </Fixtures>
         <Tiles>
-            <Manufacturer _CreationDate="2020-09-18#17:06:36" _ModifiedDate="2020-09-18#17:06:36" Name="Gantom" Comment="" Web="http://www.gantom.com"/>
+            <Manufacturer _CreationDate="2020-09-18#17:06:36" _ModifiedDate="2020-09-18#17:06:36" Name="Gantom" Comment="" Web="https://www.gantom.com"/>
         </Tiles>
     </Library>
 </Document>
\ No newline at end of file
🆚 gantom/precision-dmx: millumin
Changed outputted file gantom/precision-dmx.json 
--- removed
+++ added
@@ -6,9 +6,9 @@
     "authors": ["Brian McDade"],
     "createDate": "2020-03-28",
     "lastModifyDate": "2020-03-28"
   },
-  "manualURL": "http://www.gantom.com/wp-content/uploads/2018/07/Precision-DMX-User-Guide-1.1.pdf",
+  "manualURL": "https://www.gantom.com/wp-content/uploads/2018/07/Precision-DMX-User-Guide-1.1.pdf",
   "helpWanted": "Does the 3ch mode really exist? It is never mentioned in the manual.",
   "physical": {
     "dimensions": [44.5, 52.5, 52],
     "power": 3.8,
💤 gantom/precision-dmx: op-z Outputted files not changed.
💤 gantom/precision-dmx: qlcplus_4.12.2 Outputted files not changed.
🆚 ibiza-light/lp64-led-promo: aglight
Changed outputted file aglight_fixture_library.json 
--- removed
+++ added
@@ -15,9 +15,9 @@
         "manual": [
           "https://www.ibiza-light.com/media/catalog/product/LP64LED-PROMO_manual.pdf"
         ],
         "productPage": [
-          "https://www.ibiza-light.com/produits-38/light-effects/disco-lighting/effet-lumineux-disco/led-projector-64-dmx-promo.html"
+          "https://www.ibiza-light.com/produits-39/light-effects/disco-lighting/effet-lumineux-disco/led-projector-64-dmx-promo.html"
         ]
       },
       "physical": {
         "dimensions": [220, 220, 325],
💤 ibiza-light/lp64-led-promo: colorsource Outputted files not changed.
💤 ibiza-light/lp64-led-promo: d-light Outputted files not changed.
💤 ibiza-light/lp64-led-promo: ecue Outputted files not changed.
💤 ibiza-light/lp64-led-promo: millumin Outputted files not changed.
💤 ibiza-light/lp64-led-promo: op-z Outputted files not changed.
💤 ibiza-light/lp64-led-promo: qlcplus_4.12.2 Outputted files not changed.
🆚 mega-led-lighting/zoom-360: aglight
Changed outputted file aglight_fixture_library.json 
--- removed
+++ added
@@ -16,9 +16,9 @@
         "manual": [
           "https://www.jackodance.it/wp-content/uploads/2019/01/MJ-1006B-zoom-led-moving-head-light.pdf"
         ],
         "productPage": [
-          "https://mjledlighting.com/product/4in1-5in1-6in1-led-wash-zoom-moving-light/"
+          "https://mjledlighting.com/product/4in1-5in1-6in1-led-wash-zoom-moving-head-light/"
         ]
       },
       "physical": {
         "dimensions": [350, 460, 220],
💤 mega-led-lighting/zoom-360: colorsource Outputted files not changed.
💤 mega-led-lighting/zoom-360: d-light Outputted files not changed.
💤 mega-led-lighting/zoom-360: ecue Outputted files not changed.
💤 mega-led-lighting/zoom-360: millumin Outputted files not changed.
💤 mega-led-lighting/zoom-360: op-z Outputted files not changed.
💤 mega-led-lighting/zoom-360: qlcplus_4.12.2 Outputted files not changed.

@FloEdelmann FloEdelmann merged commit 9456a35 into master Sep 18, 2020
@FloEdelmann FloEdelmann deleted the fix-links branch September 18, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something doesn't work as intended. component-fixture Affects one or more existing fixture definitions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FloEdelmann