-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make libartnet 99% CMake compatible #24
base: master
Are you sure you want to change the base?
Conversation
- Tested to work on MacOS Sonoma (M1)
It's been a while since I've thought about autoconf & build tools, but f this is now generating config.h.in from CMakeLists.txt, does that mean that configure.ac is now redundant? |
In theory you won't need to use configure anymore, unless you want to still be able to use the old build system. Therefore there are two options.
For option two I would recommend renaming the |
Let's go for option 2) |
Then I will change a few things |
@nomis52 I have updated the PR |
Thanks, do you mind adding to the README explaining how to build with cmake Rest of it looks good. |
Sure, I can do that. What about the open points? Not all flags/defines are set correctly |
We were trying to use this project with CMake and found that we needed to add an include directory reference to the artnet subdirectory in the CMakeList.txt to get our project to compile correctly:
|
I added a
CMakeLists.txt
and edited theconfig.h.in
accordingly. It works fine on my MacBook running MacOS Sonoma (M1). A few things still need to be fixed:const
does not conform to ANSI C -> constunsigned int
if <sys/types.h> does not define -> size_t