OLMIS-6183, simplify proxy options #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Focus is on the nginx config and changing the proxy pass options. Primarly forwarding the Host header that will include the port as well as the requested address (e.g. nifi.local) and the port. This allows Nginx to be bound to ports other than 80 and 443. Further reduced the expected use-cases be assuming that Nginx as a reverse proxy will fully encapsulate Nifi and Superset, and that if a user wants to use SSL, either the termination will be done at Nginx and the configuration will include certs, or the termination may happen a level above Nginx (e.g. an AWS ELB) in which case running a server on port 443 is unneeded.
ghost
force-pushed
the
master
branch
5 times, most recently
from
01453b5
to
0685083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus is on the nginx config and changing the proxy pass options. Primarly forwarding the Host header that will include the port as well as the requested address (e.g. nifi.local) and the port. This allows Nginx to be bound to ports other than 80 and 443. Further reduced the expected use-cases be assuming that Nginx as a reverse proxy will fully encapsulate Nifi and Superset, and that if a user wants to use SSL, either the termination will be done at Nginx and the configuration will include certs, or the termination may happen a level above Nginx (e.g. an AWS ELB) in which case running a server on port 443 is unneeded.