Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driver to ohmd_list_gets, display device driver in simple example #282

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Aesthetikx
Copy link

This adds the OHMD_DRIVER to ohmd_list_gets to be more consistent with the ohmd_device_desc struct. This also displays that driver in the simple example. Reason I added this was for clarity; I was running the example on a laptop with no devices connected and was surprised to see devices connected. It is somewhat obvious that it is the dummy driver (and it says null device) but I think this improves clarity for newcomers and people possibly testing multiple devices or adding new drivers etc.

@TheOnlyJoey
Copy link
Member

As this is a API addition, it needs to be put under consideration and merged at a good time.
I will bring this in the next API discussion and see if we can mark it for a release (0.4 probably).

@Aesthetikx
Copy link
Author

As this is a API addition, it needs to be put under consideration and merged at a good time.
I will bring this in the next API discussion and see if we can mark it for a release (0.4 probably).

@TheOnlyJoey Agreed, same can be said about #284 if you like any of those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants