Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how point clustering radius is used. #983

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Mar 5, 2019

Before, it was cryptically linked to the display size, which was counter-intuitive. Now, the point clustering radius is based on display pixels.

This also removes an unnecessary dependency on vgl from the clustering algorithm.

Temporarily disable the test of the sld (WMS) example. The external server we use for that example is not responding.

This resolves issue #853.

pointFeature.clustering({radius: 0.012});
// Setting the cluster radius to the cluster point style radius is usually
// a good value.
pointFeature.clustering({radius: 10});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice @manthey this API is so much better

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API/method

@manthey manthey force-pushed the refactor-clustering-radius branch from 7b6279c to b2d969f Compare March 12, 2019 13:31
Before, it was cryptically linked to the display size, which was
counter-intuitive.  Now, the point clustering radius is based on display
pixels.

This also removes an unnecessary dependency on vgl from the clustering
algorithm.

Temporarily disable the test of the sld (WMS) example.  The external
server we use for that example is not responding.
@manthey manthey force-pushed the refactor-clustering-radius branch from b2d969f to 2a6f54d Compare March 12, 2019 13:32
@manthey manthey merged commit df138c9 into master Mar 12, 2019
@manthey manthey deleted the refactor-clustering-radius branch March 12, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants