introduce more pythonic way to install vidsum #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4383
changed the title
|
Hi @AdiChat! Can you review please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: #[Mention the issue number it fixes or add the details of the changes if it doesn't has a specific issue.]
This merge request introduce best practices about how to install properly python package.
This merge request can be following by an other merge request for deploy vidsum on pypi and users can install it from pypi
pip install vidsum.Changes:
[Add here what changes were made in this pull request.]
setuptoolsfor install package like a standard python packagepbrfor generate automaticaly release based on git tags and manage a more properly semver