fix: wrong formatting of run complete time #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logger.timer already returns a better human readable time string.
josephjclark
approved these changes
Feb 24, 2025
|
Thank you! I'll get this released |
josephjclark
added a commit
that referenced
this pull request
Feb 25, 2025
* fix: wrong formatting of run complete time (#878) * fix: wrong formatting of run complete time logger.timer already returns a better human readable time string. * changeset --------- Co-authored-by: Joe Clark <[email protected]> * Fix worker log level (#880) * ensure the jobLogLevel option gets properly fed through to the worker * fix integration test and tidy logging * version: [email protected] [email protected] * worker: remove debug code --------- Co-authored-by: Farhan Y. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Removes wrong formatting of run complete duration.
Fixes #875
Implementation Details
Easy fix.
QA Notes
Do you see msms anymore on run complete logs?
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Release branch checklist
Delete this section if this is not a release PR.
If this IS a release branch:
pnpm changeset versionfrom root to bump versionspnpm installpnpm changeset tagto generate tagsgit push --tagsTags may need updating if commits come in after the tags are first generated.