Runtime: attempt to clean up error output #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
josephjclark
added a commit
that referenced
this pull request
Jan 13, 2025
* compiler: generate a source map if a job name is passed * runtime: add a position mapping function * runtime: map error position * runtime: update test * comment * runtime: properly map positions and stack traces in errors * compiler: more tests * cli: refactor to build sourcemaps up properly * lexicon: updated typings * runtime: nicely log errors with position and line of code * runtime: tidy up * runtime: rewrite sourcemap tests and improve typings * runtime: fix tests * runtime: ensure a sourcemap is set when a workflow is generated from a string expression * tests: add tests for error types Not sure how useful this is tbh * runtime: typing * engine: adjust to new compiler API * changesets * runtime: update test * format * runtime: refine error output * tests: added error logging tests * Sourcemapping adaptor errors (#851) * runtime: refine error output * tests: added error logging tests * compiler: append positional information to top level operations * compiler: write the operations map to the souce map * lexicon: add typings for extended source map * lexicon: tweak sourcemap types * package lock * runtime: updat error handling to handle adaptor errors with source mapping * runtime: better handling of nested adaptor errors probably * runtime: update tests * cli: types * tidy * runtime: better handling of nested errors * Runtime: attempt to clean up error output (#852) * compiler: append positional information to top level operations * compiler: write the operations map to the souce map * lexicon: add typings for extended source map * lexicon: tweak sourcemap types * package lock * runtime: updat error handling to handle adaptor errors with source mapping * runtime: better handling of nested adaptor errors probably * runtime: update tests * cli: types * tidy * runtime: better handling of nested errors * runtime: improvements to reporting of errors * changeset * runtime: improve error details * runtime: better frame detection for adaptor errors * runtime: fix tests * tests: update output logs * logger: ensure timestamp is added to print logs, so that the worker can handle them properly * version: [email protected] [email protected] * tmp: worker to rc1 version * fix openfnx build Make sure dist is properly cleaned each time * runtime: simplify adaptorerror constructor * tests: fix adaptor versions * cli: skip flay test * tests: skip more flaky docs tests * worker: version to 1.9.0 * cli: update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a number of tweaks to error output to be more readable
I want to get really really good testing on this.
Examples
Examples use the CLI but the worker receives exactly the same logs
Adaptor error coming out of HTTP:
Reference error in job code:
Error inside the adaptor if config is undefined
Nice 500 error coming out of ODK
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy