[PATCH v1] api: system: allow odp_system_meminfo_t.total_overhead to be zero #2184
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odp_system_meminfo_t.total_overhead may not be supported by all implementations, so make the check conditional. Signed-off-by: Matias Elo <[email protected]>
For some implementations it may not be always feasible to fill odp_system_meminfo_t.total_overhead value. As this field is only intended for debuggin purposes, allow implementations to return zero in this field. Signed-off-by: Matias Elo <[email protected]>
odpbuild
changed the title
| @@ -277,7 +277,8 @@ static void system_test_meminfo(void) | |||
| CU_ASSERT(ret == ret_0); | |||
| CU_ASSERT(info_0.total_mapped == info.total_mapped); | |||
| CU_ASSERT(info_0.total_used == info.total_used); | |||
| CU_ASSERT(info_0.total_overhead == info.total_overhead); | |||
| if (info_0.total_overhead) | |||
There was a problem hiding this comment.
The condition does not seem necessary. Even if total_overhead is not supported, its value (zero in that case) should be the same in the two calls.
| @@ -1,6 +1,6 @@ | |||
| /* SPDX-License-Identifier: BSD-3-Clause | |||
There was a problem hiding this comment.
Typo in commit message: debuggin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.