-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RPC projection class #108
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks reasonable to me 👍 I am wondering if we should just call the model RPCModel instead of RPC_Model?
Also, do we have some test data that we can use to add testing for the model? also perhaps later we can create a general transform model for geospatial.
Yes, we can easily make up some test data, but I'm not sure where to put it or how tests are structured in gaia. |
thanks for the changes. The tests are python unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing the style as well. LGTM if we add the tests later in a separate PR.
Yes, can you have Dan help by adding the tests. I won't have time to get to it for a while. I'll send you some data. |
No description provided.