Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyphal/UDP: remove the default local_node_id #337

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cyphal/UDP: remove the default local_node_id #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ead82c
#323: change local_node_id from 0 to absent
songmeo May 3, 2024
7ff7ac2
fix test failing after updating variable
songmeo May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pycyphal/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "1.18.0"
__version__ = "1.18.1"
2 changes: 1 addition & 1 deletion pycyphal/transport/udp/_udp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class UDPTransport(pycyphal.transport.Transport):
def __init__(
self,
local_ip_address: IPAddress | str,
local_node_id: typing.Optional[int] = 0,
local_node_id: typing.Optional[int],
*, # The following parameters are keyword-only.
mtu: int = MTU_DEFAULT,
service_transfer_multiplier: int = 1,
Expand Down
2 changes: 1 addition & 1 deletion tests/application/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ async def _unittest_slow_node(compiled: typing.List[pycyphal.dsdl.GeneratedPacka
asyncio.get_running_loop().slow_callback_duration = 3.0

assert compiled
remote_pres = Presentation(UDPTransport("127.1.1.1"))
remote_pres = Presentation(UDPTransport("127.1.1.1", None))
remote_hb_sub = remote_pres.make_subscriber_with_fixed_subject_id(Heartbeat_1)
remote_info_cln = remote_pres.make_client_with_fixed_service_id(GetInfo_1, 258)

Expand Down
Loading